Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use https where possible and fix redirects #929

Merged
merged 1 commit into from
Jul 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ _No changes_.
* Added create_resource, update_resource and delete_resource hooks (thanks to Carlos Antonio da Silva).
* Backported ActionController::Responder from Rails 3.
* Added parent_url helper.
* Added association_chain helper (as suggested by http://github.com/emmanuel).
* Added association_chain helper (as suggested by https://github.com/emmanuel).

## Version 0.8

Expand All @@ -172,7 +172,7 @@ _No changes_.

* Ensure that the default template is not rendered if the default_template_format is not accepted. This is somehow related with the security breach report:

http://www.rorsecurity.info/journal/2009/4/24/hidden-actions-render-templates.html
https://rorsecurity.info/journal/2009/4/24/hidden-actions-render-templates.html

IR forbids based on mime types. For example: respond_to :html, :except => :index ensures that the index.html.erb view is not rendered, making your IR controllers safer.

Expand Down
10 changes: 5 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ has been transferred to the ActiveAdmin organization for maintenance. New featu
requests are not encouraged.

If you are not already using Inherited Resources we suggest instead using Rails'
`respond_with` feature alongside the [responders gem](https://github.com/plataformatec/responders).
`respond_with` feature alongside the [responders gem](https://github.com/heartcombo/responders).

## Inherited Resources

Expand All @@ -22,7 +22,7 @@ code by following fat models and skinny controllers convention. There are
two screencasts available besides this README:

* http://railscasts.com/episodes/230-inherited-resources
* http://akitaonrails.com/2009/09/01/screencast-real-thin-restful-controllers-with-inherited-resources
* https://www.akitaonrails.com/2009/09/01/screencast-real-thin-restful-controllers-with-inherited-resources

## Installation

Expand All @@ -49,7 +49,7 @@ $ gem install inherited_resources
Since Inherited Resources 1.0, has_scope is not part of its core anymore but
a gem dependency. Be sure to check the documentation to see how you can use it:

- <http://github.com/plataformatec/has_scope>
- <https://github.com/heartcombo/has_scope>

And it can be installed as:

Expand All @@ -64,7 +64,7 @@ but is set as Inherited Resources dependency and it's used by default by
InheritedResources controllers. Be sure to check the documentation to see
how it will change your application:

- <http://github.com/plataformatec/responders>
- <https://github.com/heartcombo/responders>

And it can be installed with:

Expand Down Expand Up @@ -737,7 +737,7 @@ MIT License. Copyright (c) 2009-2017 José Valim.
Please use the Tidelift security contact to [report a security vulnerability][Tidelift security contact].
Tidelift will coordinate the fix and disclosure.

[rubygems_badge]: http://img.shields.io/gem/v/inherited_resources.svg
[rubygems_badge]: https://img.shields.io/gem/v/inherited_resources.svg
[rubygems]: https://rubygems.org/gems/inherited_resources
[actions_badge]: https://github.com/activeadmin/inherited_resources/workflows/ci/badge.svg
[actions]: https://github.com/activeadmin/inherited_resources/actions
Expand Down
2 changes: 1 addition & 1 deletion lib/inherited_resources/base_helpers.rb
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ def association_chain
end

# rubocop:disable Layout/CommentIndentation
# See https://github.com/rubocop-hq/rubocop/issues/6450
# See https://github.com/rubocop/rubocop/issues/6450
#
# Overwrite this method to provide other interpolation options when
# the flash message is going to be set.
Expand Down