Add initial JSONs for the entity creation flows by andrewtavis · Pull Request #1809 · activist-org/activist

andrewtavis · 2025-12-21T11:46:08Z

Contributor checklist

This pull request is on a separate branch and not the main branch
I have run the tests for the backend and frontend depending on what's needed for my changes as described in the testing section of the contributing guide

Description

This will be a long term collaborative PR. We need to finalize the backend and frontend for the creation of entities (organizations, groups and events). Initial PR sends along the agreed to JSON schema that the frontend will send to the backend.

Related issue

netlify · 2025-12-21T11:46:14Z

✅ Deploy Preview for activist-org canceled.

Name	Link
🔨 Latest commit	`2fa1243`
🔍 Latest deploy log	https://app.netlify.com/projects/activist-org/deploys/699b40595f46b90008628dd9

github-actions · 2025-12-21T11:46:35Z

Thank you for the pull request! ❤️

The activist team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the General and Development rooms once you're in. Also consider attending our bi-weekly Saturday developer syncs! It'd be great to meet you 😊

Note

activist uses Conventional Comments in reviews to make sure that communication is as clear as possible.

github-actions · 2025-12-21T11:46:36Z

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

Tests for changes have been written and the TypeScript, pytest and formatting workflows within the PR checks do not indicate new errors in the files changed
The Playwright end to end and Zap penetration tests have been ran and are passing (if necessary)
The changelog has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

… composables, components and services with it too + now json for create event is sent correctly

github-actions

license-eye has checked 1226 files.

Valid	Invalid	Ignored	Fixed
920	2	304	0

Click to see the invalid file list

frontend/app/composables/mutations/useEventMutations.ts
frontend/app/services/location.ts

Use this command to fix any missing license headers

```bash

docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix

</details>

frontend/app/composables/mutations/useEventMutations.ts

frontend/app/services/location.ts

…ty-creation-flows

nicki182 · 2025-12-28T11:53:49Z

@andrewtavis and @to-sta the front end is done structure wise. I will send in the coming days to anna the current look of the front end with the create modals and start creating tests at least for the machine stores and the composable. Some vitests are breaking, I will fix them later.

andrewtavis · 2025-12-28T13:41:54Z

Thanks so much, @nicki182! Looking forward to the fixed tests and the feedback from UX on this :) Let's be in touch on a good time for us to have a chat about how it's all looking 😊

CC @archiania972 for visibility 👋

nicki182 · 2025-12-29T10:57:34Z

@andrewtavis I fixed the issues with the ci tests.
I can bring the tests later on a different PR, but it has been started and I will bring them in next week. So I can still push them in this PR.

andrewtavis · 2025-12-29T12:38:54Z

Let's plan on pushing them to this PR so we can finalize the designs along with this, @nicki182 :) I'll check in on when a call would work 😊

github-actions

license-eye has checked 1233 files.

Valid	Invalid	Ignored	Fixed
924	5	304	0

Click to see the invalid file list

frontend/test/composables/useFlowScreens.spec.ts
frontend/test/stores/create-event.spec.ts
frontend/test/stores/create-group.spec.ts
frontend/test/stores/create-organization.spec.ts
frontend/test/stores/flow.spec.ts

Use this command to fix any missing license headers

```bash

docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix

</details>

frontend/test/composables/useFlowScreens.spec.ts

github-actions · 2025-12-30T00:39:46Z

frontend/test/stores/create-event.spec.ts

@@ -0,0 +1,120 @@
+import { setActivePinia, createPinia } from "pinia";


Suggested change

import { setActivePinia, createPinia } from "pinia";

/*

* SPDX-License-Identifier: AGPL-3.0-or-later

*/

import { setActivePinia, createPinia } from "pinia";

frontend/test/stores/create-group.spec.ts

frontend/test/stores/create-organization.spec.ts

frontend/test/stores/flow.spec.ts

nicki182 · 2025-12-30T09:18:58Z

@andrewtavis done. I added some tests there is still more to do. I need to do tests for the components layers and all the new components I created

andrewtavis · 2026-02-21T11:46:38Z

Thanks, @to-sta! Generally I think we're close here, but I'm wondering on the unused variables that Ruff is bringing up, and I also want to note that removing the fields in tests like test_days_ahead_filters_events_within_window means we're not actually testing what we're supposed to be at this point as the whole point was we were passing specific times. What can we pass instead of start_time and end_time now?

And also, @to-sta, do we need test_event_api? Is this file similarly redundant now?

andrewtavis · 2026-02-21T11:53:07Z

note: Let's still try to bring this in during the sync today. If we can get the backend tests passing beforehand, then we can do a demo for those who haven't seen it and go through functionality. We can then go through the code, which I'll do as we go through the functionalities, and then we should be good to merge.

nicki182 · 2026-02-21T12:16:36Z

@andrewtavis sounds great to me

andrewtavis · 2026-02-21T17:06:56Z

Current bugs with the process:

Description not being applied to the event or org or group when it's being created
We need to refresh the page after creating a group for the group to show up (we need to refresh Nuxt data)

Issues to make:

Calendar first render creates an automatic refresh that then breaks the flow (assumption is Tailwind misalignment)
- https://www.npmjs.com/package/tailwind-merge
- Loading the calendar on open of the create modal
Topic selection dropdown is sometimes empty
Organization name not being rendered in the event Details card
Creating orgs and groups leads to the About page
Creating events should lead to the events page filtered for all events that the user just created

andrewtavis · 2026-02-21T18:12:56Z

Quick FYI @to-sta: We're removing test_event_api.py because we're seeing that coverage is the same if it's not included :)

andrewtavis · 2026-02-21T20:56:22Z

Quick notes on eec45e9, @to-sta and @nicki182:

We're now successfully sending the description for all entities
- The part that derives ISO for orgs and groups is commented out in the serializers as I wasn't able to figure out where the ISO is being added to the data for the request
- iso = validated_data.pop("iso") fails as we're not getting an iso from the frontend
- Good enough for now :)
- If we can't fix this, we can make an issue for it
The tests for backend/events/tests/test_event_filters.py are still WIP
- We want to be able to pass explicit start and end times to events via the times field as we need to be able to test based on explicit ranges being passed
- Both @sh-ran and I looked at this for a while and it wasn't apparent how we can do this
- @sh-ran will continue to check for a bit :)

Suggestions on the above would be great! Specifically:

@nicki182: Can we pass the description iso to the backend and then we can uncomment the iso = validated_data.pop("iso") in the org and group serializers
@to-sta: Let us know if you have suggestions for fixing the tests in backend/events/tests/test_event_filters.py

nicki182 · 2026-02-22T06:19:23Z

Quick notes on eec45e9, @to-sta and @nicki182:

We're now successfully sending the description for all entities

The part that derives ISO for orgs and groups is commented out in the serializers as I wasn't able to figure out where the ISO is being added to the data for the request

iso = validated_data.pop("iso") fails as we're not getting an iso from the frontend

Good enough for now :)

If we can't fix this, we can make an issue for it

The tests for backend/events/tests/test_event_filters.py are still WIP

We want to be able to pass explicit start and end times to events via the times field as we need to be able to test based on explicit ranges being passed

Both @sh-ran and I looked at this for a while and it wasn't apparent how we can do this

@sh-ran will continue to check for a bit :)

Suggestions on the above would be great! Specifically:

@nicki182: Can we pass the description iso to the backend and then we can uncomment the iso = validated_data.pop("iso") in the org and group serializers

@to-sta: Let us know if you have suggestions for fixing the tests in backend/events/tests/test_event_filters.py

@andrewtavis I can do so easily but from what I understood I was sending description but with @to-sta we arranged to be sent like this. I can do it but I want confirmation before doing the change

sh-ran · 2026-02-22T07:02:23Z

FYI @to-sta and @nicki182 : The tests for events/tests/test_events_filter.py are now passing. I have sent the changes to @andrewtavis.
Had to change the queryset.filter(start_time__gte=now, start_time__lte=end) within the filters.py to search for times__start_time__gte and times__start_time__lte as we are filtering through the related models. And some minor changes to the tests.

andrewtavis · 2026-02-22T09:26:12Z

It looks like we're sending an iso for events, but not for organizations and groups. I'm totally fine with merging this with there being a bit of a discrepancy and we can make an issue 😊

nicki182 · 2026-02-22T09:34:47Z

Ok, however you feel like. Make all the issues and we can start doing a full review of the app too

andrewtavis · 2026-02-22T17:15:40Z

backend/events/models.py

    # Explicit type annotation required for mypy compatibility with django-stubs.
    flags: Any = models.ManyToManyField("authentication.UserModel", through="EventFlag")

-    def clean(self) -> None:


Moving this to EventTime

andrewtavis · 2026-02-22T17:50:42Z

Tests are passing and all create flows are functioning 🥳 Merging this in and closing the respective issues 🚀

Add initial JSONs for the entity creation flows

5a1e021

andrewtavis requested review from nicki182, sh-ran and to-sta December 21, 2025 11:46

to-sta mentioned this pull request Dec 27, 2025

Sidebar filter icon, low contrast and unexpected behavior #1814

Closed

2 tasks

nicki182 added 2 commits December 27, 2025 17:57

chore: reworked create event with added requested changes which added…

03302c7

… composables, components and services with it too + now json for create event is sent correctly

fix: typing

8cabc11

github-actions bot reviewed Dec 27, 2025

View reviewed changes

frontend/app/composables/mutations/useEventMutations.ts Show resolved Hide resolved

frontend/app/services/location.ts Outdated Show resolved Hide resolved

nicki182 and others added 5 commits December 27, 2025 17:59

Merge remote-tracking branch 'origin/main' into entity-creation-flows

848b816

fix: headers

3973d47

Fix i18n-check errors and update frontend formatting

fb4a6ea

Merge remote-tracking branch 'origin/entity-creation-flows' into enti…

4881f30

…ty-creation-flows

chore: added services create for organizations and group

29c353c

nicki182 added 2 commits December 29, 2025 12:48

fix: tests

c56f2ed

fix: prettier

3f79ca9

nicki182 added 2 commits December 30, 2025 02:34

chore: added tests for machine architecture

47ce95e

Merge remote-tracking branch 'origin/main' into entity-creation-flows

06f1493

github-actions bot reviewed Dec 30, 2025

View reviewed changes

nicki182 added 4 commits December 30, 2025 11:03

fix: fix tests, format and added missing liscensing headers

09680d0

fix: removed unnecesary file

12e024e

fix: added missing header in file

2b600e2

fix: build

273f1bb

andrewtavis added 2 commits February 21, 2026 12:42

Remove old fields from backend tests - wip

b75454d

Update pytest docs

b45e680

andrewtavis added 2 commits February 21, 2026 18:18

Restart groups of orgs after a new one has been created

1d03737

Move store declaration inside of function

4afd748

andrewtavis added 2 commits February 21, 2026 19:15

Remove unneeded backend test file

7c93ec1

Send description texts to backend on create + test fix attempt - wip

eec45e9

andrewtavis added 5 commits February 22, 2026 16:58

Fixes for backend tests

5dc6186

Merge branch 'main' into entity-creation-flows

6220cb0

i18n-check fixes

8b61a35

Fix Ruff issue - wip comment out unused variable

9e5484f

Fixes for final backend tests - assign topic type from topics.json

2d32f83

andrewtavis commented Feb 22, 2026

View reviewed changes

andrewtavis added 5 commits February 22, 2026 18:19

Add back in validation of start time and end time + minor clean up

829167a

Fix test for assigning multiple topics to groups

af6243a

Add comment on choice of fixing group topics test

38d3f32

Remove unneeded JSONs and fix the test of multiple org topics

d800d98

Final fix to backend Python tests

2fa1243

andrewtavis merged commit eb2ec80 into main Feb 22, 2026
8 checks passed

andrewtavis deleted the entity-creation-flows branch February 22, 2026 17:50

		@@ -0,0 +1,120 @@
		import { setActivePinia, createPinia } from "pinia";

Comments

Conversation

andrewtavis commented Dec 21, 2025 • edited by nicki182 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contributor checklist

Description

Related issue

Uh oh!

netlify bot commented Dec 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for activist-org canceled.

Uh oh!

github-actions bot commented Dec 21, 2025

Thank you for the pull request! ❤️

Uh oh!

github-actions bot commented Dec 21, 2025 • edited by andrewtavis Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Maintainer Checklist

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nicki182 commented Dec 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andrewtavis commented Dec 28, 2025

Uh oh!

nicki182 commented Dec 29, 2025

Uh oh!

andrewtavis commented Dec 29, 2025

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot Dec 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nicki182 commented Dec 30, 2025

Uh oh!

andrewtavis commented Feb 21, 2026

Uh oh!

andrewtavis commented Feb 21, 2026

Uh oh!

nicki182 commented Feb 21, 2026

Uh oh!

andrewtavis commented Feb 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andrewtavis commented Feb 21, 2026

Uh oh!

andrewtavis commented Feb 21, 2026

Uh oh!

nicki182 commented Feb 22, 2026

Uh oh!

sh-ran commented Feb 22, 2026

Uh oh!

andrewtavis commented Feb 22, 2026

Uh oh!

nicki182 commented Feb 22, 2026

Uh oh!

andrewtavis Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

andrewtavis commented Feb 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

andrewtavis commented Dec 21, 2025 •

edited by nicki182

Loading

netlify bot commented Dec 21, 2025 •

edited

Loading

github-actions bot commented Dec 21, 2025 •

edited by andrewtavis

Loading

nicki182 commented Dec 28, 2025 •

edited

Loading

andrewtavis commented Feb 21, 2026 •

edited

Loading