Skip to content

feat: password crack time logic #1905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nicolewu0901 wants to merge 1 commit into
base: main
Choose a base branch
from
+31,588 −15,599
Open

feat: password crack time logic #1905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 21 additions & 32 deletions frontend/app/components/indicator/IndicatorPasswordStrength.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,10 @@
}"
data-testid="sign-in-password-strength-text"
>
{{ $t("i18n.components.indicator_password_strength.title") }}:
{{
$t(
!!(password || []).length
? text
: "i18n.components.indicator_password_strength.invalid"
)
!!(password || []).length
? $t("i18n.components.indicator_password_strength.time_to_crack", { time: crackTimeDisplay })
: $t("i18n.components.indicator_password_strength.invalid")
}}
</div>
</div>
Expand All @@ -38,50 +35,42 @@ const props = defineProps<{
passwordValue?: string | Ref<string | undefined>;
}>();

const password = computed(() => unref(props.passwordValue));
const width = computed(() => (score.value + 1) * 20);
const color = computed(() => passwordStrengthMap[score.value].color);
const text = computed(() => passwordStrengthMap[score.value].text);

const password = computed(() => unref(props.passwordValue));
type PasswordIndexKey = 0 | 1 | 2 | 3 | 4;

const passwordStrengthMap: Record<
PasswordIndexKey,
{ color: string; text: string }
{ color: string }
> = {
0: {
color: "bg-password-strength-very-weak",
text: "i18n.components.indicator_password_strength.very_weak",
},
1: {
color: "bg-password-strength-weak",
text: "i18n.components.indicator_password_strength.weak",
},
2: {
color: "bg-password-strength-medium",
text: "i18n.components.indicator_password_strength.medium",
},
3: {
color: "bg-password-strength-strong",
text: "i18n.components.indicator_password_strength.strong",
},
4: {
color: "bg-primary-text",
text: "i18n.components.indicator_password_strength.very_strong",
},
0: { color: "bg-password-strength-very-weak" },
1: { color: "bg-password-strength-weak" },
2: { color: "bg-password-strength-medium" },
3: { color: "bg-password-strength-strong" },
4: { color: "bg-primary-text" },
};

const SCORE_THRESHOLDS: number[] = [6, 9, 11.5, 13.5, 15];

// Finds the case where guessLog is less than the value among those specified in the SCORE_THRESHOLDS array.
// Calculate score for the progress bar width/color
const score = computed((): PasswordIndexKey => {
if (!password.value) return 0;
const guessLog: number = zxcvbn(password.value as string).guesses_log10;
const result = zxcvbn(password.value as string);
const guessLog: number = result.guesses_log10;
const scoreIndex = SCORE_THRESHOLDS.findIndex(
(threshold) => guessLog < threshold
);
return (
scoreIndex >= 0 ? scoreIndex : SCORE_THRESHOLDS.length - 1
) as PasswordIndexKey;
});
</script>

// NEW CODE: Extract the crack time string from zxcvbn
const crackTimeDisplay = computed(() => {
if (!password.value) return "";
const result = zxcvbn(password.value as string);
return result.crack_times_display.offline_slow_hashing_1e4_per_second;
});
</script>
1 change: 1 addition & 0 deletions frontend/i18n/locales/en-US.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,7 @@
"i18n.components.indicator_password_strength.invalid": "invalid",
"i18n.components.indicator_password_strength.medium": "medium",
"i18n.components.indicator_password_strength.strong": "strong",
"i18n.components.indicator_password_strength.time_to_crack": "Time to crack: {time}",
"i18n.components.indicator_password_strength.title": "Password strength",
"i18n.components.indicator_password_strength.very_strong": "very strong",
"i18n.components.indicator_password_strength.very_weak": "very weak",
Expand Down
Loading