Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build error introduced by previous commit #1224

Merged
merged 1 commit into from
Jan 13, 2024

Conversation

kcaliban
Copy link
Contributor

@kcaliban kcaliban commented Jan 13, 2024

Note that the check-index-version workflow will still fail for this commit because it checks out the previous version of the master, which because of the build error we are fixing here does not compile. Everything should be fine again starting with the next commit after this one.

Copy link

codecov bot commented Jan 13, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (c00a2b5) 84.26% compared to head (d182ace) 84.30%.
Report is 1 commits behind head on master.

Files Patch % Lines
src/engine/GroupBy.h 88.46% 0 Missing and 3 partials ⚠️
src/engine/GroupBy.cpp 99.26% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1224      +/-   ##
==========================================
+ Coverage   84.26%   84.30%   +0.04%     
==========================================
  Files         304      304              
  Lines       29009    29091      +82     
  Branches     3428     3440      +12     
==========================================
+ Hits        24443    24524      +81     
  Misses       3163     3163              
- Partials     1403     1404       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@hannahbast hannahbast changed the title Fix build Fix build error introduced by previous commit Jan 13, 2024
@hannahbast
Copy link
Member

@kcaliban Thanks for the fix, but check-index-version (gcc, 11, -Wall -Wextra -O1 , Debug) is still unhappy.

@kcaliban
Copy link
Contributor Author

kcaliban commented Jan 13, 2024

@kcaliban Thanks for the fix, but check-index-version (gcc, 11, -Wall -Wextra -O1 , Debug) is still unhappy.

@hannahbast If I am not mistaken, that check looks at the current HEAD of the master branch at ad-freiburg/qlever, which fails because ad_utility::isTypeContainedIn was renamed in a previous commit but is used in the code that was merged in the last commit.

Copy link
Member

@hannahbast hannahbast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix and the explanation why the check-index-version workflow fails (because it also checks out the current version of the master, which as we know does not compile). I will merge this now.

@hannahbast hannahbast merged commit 34af3a7 into ad-freiburg:master Jan 13, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants