Fix the address and thread sanitizer builds on newer kernels #1304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1304 +/- ##
==========================================
+ Coverage 88.09% 88.10% +0.01%
==========================================
Files 310 310
Lines 28436 28436
Branches 3148 3148
==========================================
+ Hits 25050 25053 +3
Misses 2231 2231
+ Partials 1155 1152 -3 ☔ View full report in Codecov by Sentry. |
|
joka921
changed the title
|
Recent versions of the linux kernel and also recent versions of the Ubuntu distributions have increased the number of bits that are used for virtual address layout randomization. The sanitizer tools have to be aware of this randomization but have not yet picked up that change. Our current fix is to manually reduce the number of randomization bits back to 28 (the previous value) for our GitHub actions builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent versions of the linux kernel and also recent versions of the Ubuntu distributions have increased the number of bits that are used for virtual address layout randomization. The sanitizer tools have to be aware of this randomization but have not yet picked up that change. Our current fix is to manually reduce the number of randomization bits back to 28 (the previous value) for our GitHub actions builds.