Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a small bug in the TurtleParser #1311

Merged

Conversation

joka921
Copy link
Member

@joka921 joka921 commented Mar 22, 2024

Since #1301, triples were the subject is an explicit blank node (for example _:x <is-a> <blankNode>.) could no longer be parsed. This commit fixes this bug and adds a unit test for this case.

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.10%. Comparing base (7ad3f58) to head (31bc56e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1311   +/-   ##
=======================================
  Coverage   88.09%   88.10%           
=======================================
  Files         313      313           
  Lines       28503    28503           
  Branches     3155     3155           
=======================================
+ Hits        25110    25112    +2     
  Misses       2235     2235           
+ Partials     1158     1156    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@hannahbast hannahbast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this quick fix! It looks good + I built indexes with it for several datasets (where it didn't work without the fix) and everything worked fine.

@hannahbast hannahbast merged commit 9dc0fc0 into ad-freiburg:master Mar 23, 2024
19 checks passed
@joka921 joka921 deleted the fix-subject-blanknodes-turtle-parser branch April 11, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants