Clean up some header includes to slightly improve the build time #1319
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1319 +/- ##
=======================================
Coverage 88.36% 88.37%
=======================================
Files 313 316 +3
Lines 28444 28440 -4
Branches 3138 3138
=======================================
- Hits 25134 25133 -1
+ Misses 2173 2168 -5
- Partials 1137 1139 +2 ☔ View full report in Codecov by Sentry. |
src/global/ValueIdComparators.h
Outdated
| return a.visit([&](const auto& aValue) { | ||
| return b.visit([&](const auto& bValue) -> ComparisonResult { | ||
| if constexpr (requires() { std::invoke(comparator, aValue, bValue); }) { | ||
| return fromBool(std::invoke(comparator, aValue, bValue)); | ||
| } else { | ||
| AD_FAIL(); | ||
| } |
There was a problem hiding this comment.
With our updated compiler versions and consistent with a change that I have in the pipeline we can now simply write
return std::visit([&}(const auto& aValue, const auto& bValue) {...}, a, b);
There was a problem hiding this comment.
Okay, we can't because those are not std::variant at all, but I am currently merging the conflict there myself.
src/index/IndexMetaDataImpl.h
Outdated
| #include "../util/File.h" | ||
| #include "../util/Serializer/ByteBufferSerializer.h" | ||
| #include "../util/Serializer/FileSerializer.h" | ||
| #include "../util/Serializer/SerializeHashMap.h" |
There was a problem hiding this comment.
These can and should also all be "util/Serializer/..." (absolute paths) while you are at it.
# Conflicts: # src/global/ValueIdComparators.h
|
joka921
changed the title
RuntimeParameters (which are only used in a few places but are very expensive to parse) into their own header. They used to be part of the globalConstants.hfile, which is included almost everywhere.gtest.hbygtest_prod.hin places where only theFRIEND_TESTmacro is needed..cppfiles.