Fix a subtle bug in CompressedExternalIdTableSorter
#1328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1328 +/- ##
==========================================
+ Coverage 88.37% 88.67% +0.30%
==========================================
Files 316 321 +5
Lines 28440 28514 +74
Branches 3138 3140 +2
==========================================
+ Hits 25133 25286 +153
+ Misses 2168 2090 -78
+ Partials 1139 1138 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Johannes Kalmbach <[email protected]>
hannahbast
approved these changes
Apr 17, 2024
hannahbast
changed the title
|
hannahbast
changed the title
CompressedExternalIdTableSorter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under certain (rare) conditions,
CompressedExternalIdTableSorter::sortedBlocksproduced empty blocks, which led to an exception. This is now fixed. Also make sure that an exception in the building of a permutation pair does not result in a deadlock anymore (as it did for the bug just mentioned), but in a proper error message.