Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use LiteralOrIri instead of std::string in LocalVocab #1333

Merged
merged 3 commits into from
May 3, 2024

Conversation

joka921
Copy link
Member

@joka921 joka921 commented Apr 26, 2024

Continue work started with #1186 (which introduced the class LiteralOrIri) and #1318 (which used LiteralOrIri instead of std::string in all SPARQL expressions). This change now uses LiteralOrIri instead of std::string whenever dealing with words from a LocalVocab.

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 88.81%. Comparing base (07a42ef) to head (13a7542).

Files Patch % Lines
src/engine/ExportQueryExecutionTrees.cpp 94.11% 1 Missing ⚠️
src/engine/GroupByHashMapOptimization.h 83.33% 1 Missing ⚠️
...sparqlExpressions/SparqlExpressionValueGetters.cpp 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1333      +/-   ##
==========================================
- Coverage   88.84%   88.81%   -0.03%     
==========================================
  Files         322      322              
  Lines       28512    28515       +3     
  Branches     3144     3143       -1     
==========================================
- Hits        25331    25327       -4     
- Misses       2041     2046       +5     
- Partials     1140     1142       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@hannahbast hannahbast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1-1 with Johannes, thanks a lot + some minor changes

@hannahbast hannahbast changed the title Use LiteralOrIri for the LocalVocab Use LiteralOrIri also in LocalVocab May 2, 2024
Copy link

sonarqubecloud bot commented May 2, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@hannahbast hannahbast changed the title Use LiteralOrIri also in LocalVocab Use LiteralOrIri for all entries in a LocalVocab May 3, 2024
@hannahbast hannahbast changed the title Use LiteralOrIri for all entries in a LocalVocab Use LiteralOrIri instead of std::string in LocalVocab May 3, 2024
@hannahbast hannahbast merged commit 5373efe into ad-freiburg:master May 3, 2024
18 of 19 checks passed
@joka921 joka921 deleted the literal-or-iri-local-vocab branch December 18, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants