Better error message for accidental Cartesian-product join #1339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahbast
changed the title
…uct' into error-message-oom-cartesian-product
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1339 +/- ##
=======================================
Coverage 88.82% 88.82%
=======================================
Files 322 322
Lines 28548 28556 +8
Branches 3149 3149
=======================================
+ Hits 25357 25365 +8
Misses 2049 2049
Partials 1142 1142 ☔ View full report in Codecov by Sentry. |
|
hannahbast
approved these changes
May 6, 2024
hannahbast
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mistyping a variable can easily lead to a Cartesian-product join with a very large result, for example: https://qlever.cs.uni-freiburg.de/wikidata/h6p82D . This change provides a more helpful error message in case that happens, as suggested in #1309.