Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement casting/mapping towards datatype xsd:dateTime and xsd:date. #1825

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

realHannes
Copy link
Collaborator

This PR provides the implementation for request Issue #1819 @hannahbast .

xsd:date(?dateStr) and xsd:dateTime(?dateTimeStr) are now implemented as built-in function calls which enable variable value datatype-casting from xsd:string to xsd:dateTime (+ xsd:date ).

@realHannes realHannes changed the title Implement casting/mapping towards datatypes xsd:dateTime and xsd:date. Implement casting/mapping towards datatype xsd:dateTime and xsd:date. Feb 20, 2025
@realHannes realHannes requested a review from joka921 February 20, 2025 18:31
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 98.13084% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.19%. Comparing base (8fe0642) to head (9d3009f).

Files with missing lines Patch % Lines
src/util/DateYearDuration.cpp 94.44% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1825      +/-   ##
==========================================
+ Coverage   90.18%   90.19%   +0.01%     
==========================================
  Files         400      400              
  Lines       38440    38501      +61     
  Branches     4306     4316      +10     
==========================================
+ Hits        34666    34725      +59     
- Misses       2479     2480       +1     
- Partials     1295     1296       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@joka921 joka921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, that looks very nice.

Copy link
Member

@joka921 joka921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, only two minor comments remaining

@sparql-conformance
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants