Sharks - Jeannie #111
Open
Sharks - Jeannie #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spitsfire
reviewed
Jun 10, 2022
| } else { | ||
| playerHand.push(randomCharacter); | ||
| LETTER_POOL[randomCharacter] -= 1; | ||
| alphabet.replace(randomCharacter, ''); |
There was a problem hiding this comment.
love this idea! One thing I would suggest is turning alphabet into an array instead of a string. That way when we change the index position's value to an empty string, we aren't creating a whole new copy of the data structure the way replace is doing.
Each time we call replace it has to make a new copy of the string.
| }; | ||
|
|
||
|
|
||
| export const usesAvailableLetters = (input, lettersInHand) => { |
Comment on lines
+117
to
+119
| } if (word.length >= 7) { | ||
| score += 8; | ||
| } |
There was a problem hiding this comment.
I think standard practice is to have the if statement start on its own line. I only ever see a conditional on the same line as a closing curly brace is with else
Suggested change
| } if (word.length >= 7) { | |
| score += 8; | |
| } | |
| } | |
| if (word.length >= 7) { | |
| score += 8; | |
| } |
| @@ -1,15 +1,157 @@ | |||
|
|
|||
| const score_chart = { | |||
There was a problem hiding this comment.
oop careful! use camel case in JavaScript:
Suggested change
| const score_chart = { | |
| const scoreChart = { |
Comment on lines
+126
to
+128
| let score_list = []; | ||
| let max_score = 0; | ||
| let winning_word = ""; |
There was a problem hiding this comment.
Suggested change
| let score_list = []; | |
| let max_score = 0; | |
| let winning_word = ""; | |
| let scoreList = []; | |
| let maxScore = 0; | |
| let winningWord = ""; |
| if (item["score"] === max_score && item["word"].length === 10) { | ||
| winner = item; | ||
| return winner; | ||
| } else if (item["score"] === max_score && item["word"].length < winning_word.length) { |
There was a problem hiding this comment.
Suggested change
| } else if (item["score"] === max_score && item["word"].length < winning_word.length) { | |
| } | |
| else if (item["score"] === max_score && item["word"].length < winning_word.length) { |
| }; | ||
|
|
||
|
|
||
| export const highestScoreFrom = (words) => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.