Skip to content

syncing idna to 0.5.5#1149

Merged
anonrig merged 1 commit into
mainfrom
anothersync
May 26, 2026
Merged

syncing idna to 0.5.5#1149
anonrig merged 1 commit into
mainfrom
anothersync

Conversation

@lemire
Copy link
Copy Markdown
Member

@lemire lemire commented May 25, 2026

This version uses more modern code (C++20).

@lemire lemire requested a review from anonrig May 25, 2026 21:42
@codecov
Copy link
Copy Markdown

codecov Bot commented May 25, 2026

Codecov Report

❌ Patch coverage is 40.90909% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.81%. Comparing base (9463d20) to head (8e1cccc).

Files with missing lines Patch % Lines
src/ada_idna.cpp 40.90% 2 Missing and 11 partials ⚠️

❌ Your patch check has failed because the patch coverage (40.90%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1149      +/-   ##
==========================================
- Coverage   59.87%   59.81%   -0.06%     
==========================================
  Files          37       37              
  Lines        6133     6127       -6     
  Branches     2978     2978              
==========================================
- Hits         3672     3665       -7     
  Misses        617      617              
- Partials     1844     1845       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@anonrig
Copy link
Copy Markdown
Member

anonrig commented May 25, 2026

fuzzer seems to be failing

@anonrig anonrig merged commit 215d614 into main May 26, 2026
52 of 55 checks passed
@anonrig anonrig deleted the anothersync branch May 26, 2026 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants