perf: improve has_tabs_or_newline performance#670
Merged
Conversation
lemire
approved these changes
May 17, 2024
Member
lemire
left a comment
lemire
left a comment
There was a problem hiding this comment.
This is fine, but I bet you can do it with a lambda. Note that you are doing just the NEON routine, you could do the others as well.
I expect that this will not change performance. However, it can make the code more concise, which is good.
jasnell
approved these changes
May 17, 2024
Member
|
@anonrig good to go |
anonrig
force-pushed
the
perf-improve-has-tabs
branch
from
4c4f35d to
99ae41d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems to slightly reduce the instruction count for
url_aggregator, but please run local benchmarks to verifyBefore:
After: