-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add possibility to set power mode, add function for calculate sea level pressure #5
base: master
Are you sure you want to change the base?
Conversation
hiya you removed some functions, which makes it impossible for us to merge. please try splitting the PR into multiple small branches for each change, but don't delete functions. |
document and improve code
Indeed, I am merging the configuration functions into one. |
hiya its possible to do this withoutt breakint existing functionality - please update the PR and we can merge it |
Add setconfig function:
Add getSealevelPressure function:
Return sea level pressure in Pa according to the local altitude in meter and atmospheric pressure in Pa.
Modif performReading function to remove redundancies:
No need to redefine all settings at each reading, only power mode should be if it is set to forced mode.
Modif readAltitude function:
Sea level pressure param must be now defined in Pa. Now, for simplicity, all the params and values returned from the API are in Pa
Delete setTemperatureOversampling, setPressureOversampling, setIIRFilterCoeff and setOutputDataRate functions.
Not needed anymore.
It's my first coding in c/c++/ardui, I see this as an exercise, remarks are welcome :)
Have fun.