Force pylint version 1.9.2 #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kattni
suggested changes
Oct 23, 2018
Contributor
kattni
left a comment
kattni
left a comment
There was a problem hiding this comment.
Thanks for adding this! As you can see, travisci failed. I believe the issue is that the adafruit_bmp280.py file was linted under the newer Pylint version. Please remove the #pylint: disable=useless-import-alias lines from:
and
That should resolve the issue. Make those changes locally and push to the same branch to update this PR. Thank you!
`#pylint: disable=useless-import-alias` is not supported in Pylint 1.9.2
kattni
approved these changes
Oct 25, 2018
tannewt
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Oct 26, 2018
Updating https://github.com/adafruit/Adafruit_CircuitPython_BMP280 to 3.0.8 from 3.0.7: > Merge pull request adafruit/Adafruit_CircuitPython_BMP280#8 from process1183/pylint > Merge pull request adafruit/Adafruit_CircuitPython_BMP280#9 from process1183/blinka > ignore the board module imports in .pylintrc Updating https://github.com/adafruit/Adafruit_CircuitPython_MatrixKe to 1.1.2 from 1.1.1: > Merge pull request adafruit/Adafruit_CircuitPython_MatrixKe#4 from kattni/update-example > ignore the board module imports in .pylintrc > Merge pull request adafruit/Adafruit_CircuitPython_MatrixKe#3 from kattni/example-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added forced reinstallation of pylint 1.9.2 to the .travis.yml, similar to many other Adafruit CircuitPython libraries.
I made this addition because it was listed under "PyLint version not fixed - 9" in adafruit/circuitpython#1246