Extended library for TMP116, TMP117, TMP119 #17

ami3go · 2024-05-16T16:29:51Z

I extended library to be compatible with TMP116, TMP117, TMP119 devices.
All of them have same register map and resolution.
I added:

methods: .temperature_updated if application need to receive only updated values
modified configurable variables in this was that allow IDE use autocompletion:
- such as verageCount.AVERAGE_32X, or MeasurementDelay.DELAY_0_0015_S
Added round(x,3) for temperature. Resolution is only 7m degC, there is no need to have more then 3 digits

Wait for updated result and read temperature

mistake corrrection

dhalbert

We don't sell other than TMP11x, so I'm going to inquire about whether we would want to include this in our own library. You're of course welcome to fork the library.

Do these each have different I2C addresses? There was inconsistency about that in the code examples.

Suggestion: instead of checking the device ID for each device, change to a single TMP11x class which accepts any of the device ID's. ~~Assuming the I2C addresses differ, define constants for each address. That will take less code.~~ (They don't differ inherently, I think i see.)

The additional names for autocompletion use up space in the library, so we'd avoid that. It's too bad -- I don't know of another way to make the names available easily.

dhalbert · 2024-05-16T16:37:56Z

README.rst

@@ -41,13 +45,13 @@ PyPI <https://pypi.org/project/adafruit-circuitpython-tmp117/>`_. To install for

 .. code-block:: shell

-    pip3 install adafruit-circuitpython-tmp117
+    pip3 install git+https://github.com/ami3go/Adafruit_CircuitPython_TMP11X.git


I don't think you mean to do this.

Suggested change

pip3 install git+https://github.com/ami3go/Adafruit_CircuitPython_TMP11X.git

pip3 install adafruit-circuitpython-tmp11x

Hello thanks for review, and your feedback.
That was my worry too, that you sell only one part and there is no logic to merge updated lib, because it could be confusing for your customers.
Thank for idea to integrate all 3 device into 1 class instead of 3 different.

Regarding readme . i will correct it if you going to merge it.
just for now it would be confusing if someone going to install original lib and it will not work with tmp116

dhalbert · 2024-05-16T16:38:03Z

README.rst


 To install system-wide (this may be required in some cases):

 .. code-block:: shell

-    sudo pip3 install adafruit-circuitpython-tmp117
+    sudo pip3 install git+https://github.com/ami3go/Adafruit_CircuitPython_TMP11X.git


dhalbert · 2024-05-16T16:38:10Z

README.rst

@@ -56,7 +60,7 @@ To install in a virtual environment in your current project:
    mkdir project-name && cd project-name
    python3 -m venv .venv
    source .venv/bin/activate
-    pip3 install adafruit-circuitpython-tmp117
+    pip3 install git+https://github.com/ami3go/Adafruit_CircuitPython_TMP11X.git


dhalbert · 2024-05-16T16:41:10Z

README.rst

+    t1 = TMP116(i2c_bus=i2c, address=0x49)
+    # t2 = TMP117(i2c_bus=i2c, address=0x49)
+    # t2 = TMP119(i2c_bus=i2c, address=0x49)


Are the I2C addresses all the same? If so don't bother to specify the address here, since the default is fine and makes usage easier.

It appears the default I2C address is the same. It's just that it can be varied via pin settings.

dhalbert · 2024-05-16T16:41:46Z

adafruit_tmp11X.py

@@ -2,10 +2,10 @@
 #
 # SPDX-License-Identifier: MIT
 """
-`adafruit_tmp117`
+`adafruit_tmp11X`


use lower-case x for filename

and TMP11X (upper case) for new classname.

dhalbert · 2024-05-16T16:43:17Z

adafruit_tmp11X.py

+    DELAY_0_0015_S = None
+    DELAY_0_125_S = None
+    DELAY_0_250_S = None
+    DELAY_0_500_S = None
+    DELAY_1_S = None
+    DELAY_4_S = None
+    DELAY_8_S = None
+    DELAY_16_S = None


Suggested change

DELAY_0_0015_S = None

DELAY_0_125_S = None

DELAY_0_250_S = None

DELAY_0_500_S = None

DELAY_1_S = None

DELAY_4_S = None

DELAY_8_S = None

DELAY_16_S = None

dhalbert · 2024-05-16T16:43:28Z

adafruit_tmp11X.py

+    WINDOW = None
+    HYSTERESIS = None


Suggested change

WINDOW = None

HYSTERESIS = None

dhalbert · 2024-05-16T16:43:37Z

adafruit_tmp11X.py

+    CONTINUOUS = None
+    ONE_SHOT = None
+    SHUTDOWN = None


Suggested change

CONTINUOUS = None

ONE_SHOT = None

SHUTDOWN = None

dhalbert · 2024-05-16T16:43:55Z

adafruit_tmp11X.py

        # currently set when `alert_status` is read, but not exposed
        self.reset()
        self.initialize()

+    # thsi methods is unique for each device


Suggested change

# thsi methods is unique for each device

# this method is unique for each device

dhalbert · 2024-05-16T16:45:20Z

examples/Sensors_array.py

+t1 = TMP116(i2c_bus=i2c, address=0x49)
+# t2 = TMP116(i2c_bus=i2c, address=0x47)
+# t3 = TMP116(i2c_bus=i2c, address=0x48)


Here, they do have different I2C addresses.

dhalbert · 2024-05-16T17:20:31Z

README.rst

+It is forked from Adafruit_CircuitPython_TMP117, updated and extended to use it with TMP116 and TMP119
+


Suggested change

It is forked from Adafruit_CircuitPython_TMP117, updated and extended to use it with TMP116 and TMP119

``

dhalbert · 2024-05-16T17:32:03Z

README.rst

+    t1 = TMP116(i2c_bus=i2c, address=0x49)
+    # t2 = TMP117(i2c_bus=i2c, address=0x49)
+    # t2 = TMP119(i2c_bus=i2c, address=0x49)


It appears the default I2C address is the same. It's just that it can be varied via pin settings.

dhalbert · 2024-05-16T17:38:04Z

adafruit_tmp11X.py

@@ -539,4 +565,17 @@ def _read_status(self) -> Tuple[int, int, int]:
        return (high_alert, low_alert, data_ready)

    def _read_temperature(self) -> float:
-        return self._raw_temperature * _TMP117_RESOLUTION
+        return round(self._raw_temperature * _TMP117_RESOLUTION, 3)


Don't round here, because the extra digits are still interesting when summing or averaging. Leave it up to the caller to round as needed.

Suggested change

return round(self._raw_temperature * _TMP117_RESOLUTION, 3)

return self._raw_temperature * _TMP117_RESOLUTION```

Also this specifically mentions the TMP117 resolution: does the value change? Should it be TMP11X_RESOLUTION?

dhalbert · 2024-05-16T17:38:37Z

adafruit_tmp11X.py

@@ -2,10 +2,10 @@
 #
 # SPDX-License-Identifier: MIT
 """
-`adafruit_tmp117`
+`adafruit_tmp11X`


and TMP11X (upper case) for new classname.

recrements

FoamyGuy · 2024-08-26T12:50:28Z

requirements.txt

+pandas~=2.1.1
+colorama~=0.4.6
+nidaqmx~=1.0.0
+VotschTechnikClimateChamber~=0


Why have all of these modules been added to the requirements.txt file?

Are any / all of these absolutely necessary? Many of them don't have analogous modules in CircuitPython so there functionality will not be possible to use on microcontrollers.

I am in favor of removing these, unless if there are any that are strictly necessary for the operation of this library then they can remain.

ami3go and others added 11 commits May 16, 2024 16:15

library adapted for wide TMP116, TMP117, TMP119

846cb09

added temperature_updated methods

ec5e94a

Wait for updated result and read temperature

Update README.rst

d3c580f

mistake corrrection

Update README.rst

fcbadb1

Update README.rst

c92229b

Update README.rst

c8cb178

Update README.rst

90075d1

Update README.rst

342e2c5

Rewrite code to enable auto code completion for variables

e5bdacd

correct examples

9b36367

Create Sensors_array.py

a411866

dhalbert requested changes May 16, 2024

View reviewed changes

ami3go added 2 commits May 31, 2024 15:02

added Text Symbols for easy printing degC

9026e48

Update requirements.txt

92fa34b

recrements

FoamyGuy reviewed Aug 26, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Extended library for TMP116, TMP117, TMP119 #17

Extended library for TMP116, TMP117, TMP119 #17

ami3go commented May 16, 2024

dhalbert left a comment •

edited

Loading

dhalbert May 16, 2024

ami3go May 17, 2024

ami3go May 17, 2024

dhalbert May 16, 2024

dhalbert May 16, 2024

dhalbert May 16, 2024

dhalbert May 16, 2024

dhalbert May 16, 2024 •

edited

Loading

dhalbert May 16, 2024

dhalbert May 16, 2024

dhalbert May 16, 2024

dhalbert May 16, 2024

dhalbert May 16, 2024 •

edited

Loading

dhalbert May 16, 2024

dhalbert May 16, 2024

dhalbert May 16, 2024

dhalbert May 16, 2024

dhalbert May 16, 2024

FoamyGuy Aug 26, 2024

	pip3 install git+https://github.com/ami3go/Adafruit_CircuitPython_TMP11X.git
	pip3 install adafruit-circuitpython-tmp11x

	# thsi methods is unique for each device
	# this method is unique for each device

		It is forked from Adafruit_CircuitPython_TMP117, updated and extended to use it with TMP116 and TMP119

	return round(self._raw_temperature * _TMP117_RESOLUTION, 3)
	return self._raw_temperature * _TMP117_RESOLUTION```

Extended library for TMP116, TMP117, TMP119 #17

Are you sure you want to change the base?

Extended library for TMP116, TMP117, TMP119 #17

Conversation

ami3go commented May 16, 2024

dhalbert left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dhalbert May 16, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dhalbert May 16, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dhalbert left a comment •

edited

Loading

dhalbert May 16, 2024 •

edited

Loading

dhalbert May 16, 2024 •

edited

Loading