Update to use pre compiled mpy-cross binaries #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed from fetch-submodules to fetch-all-submodules. The error message "No rule to make target 'fetch-submodules'. Stop." might be resolved by using the correct make targets. Here are some relevant findings from the adafruit/circuitpython repository: Makefile Targets: fetch-translate-submodules: Fetches submodules for translation. fetch-all-submodules: Fetches submodules for all ports. Relevant Issues: Issue #9301: Discusses issues with submodule fetching in CI actions. Issue #9552: Details on setup documentation and fetching submodules for the Espressif build environment. Issue #8027: Provides information on issues related to building with submodules. To resolve the issue, you can try running: make fetch-all-submodules For more details on related issues, you can view the full list of discussions here.
|
Not sure if there is a better way or maybe not include a default version, the default version could get outdated pretty quickly and require frequent changes. Any thoughts or preferences? I guess based on the change frequency I would lean no default and the user having to specify the version. |
|
Hi! Sorry this slipped by me, let me take a look over the next couple days and get back to you! |
|
Sounds good.. I do use a copy of the checked in code on my other projects and its seems to be working.
My only note is I might consider removing the default version and leave that to the user to be in charge since the version of CP moves pretty quick.
…________________________________
From: Alec Delaney ***@***.***>
Sent: Monday, March 10, 2025 2:00 PM
To: adafruit/build-mpy ***@***.***>
Cc: Jason Jackson ***@***.***>; Author ***@***.***>
Subject: Re: [adafruit/build-mpy] Update to use pre compiled mpy-cross binaries (PR #19)
Hi! Sorry this slipped by me, let me take a look over the next couple days and get back to you!
—
Reply to this email directly, view it on GitHub<#19 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAN7MKZEHR5PZK7CYJIAN732TXOM5AVCNFSM6AAAAABXEZJO76VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMJRGQYDMMZXHA>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
[tekktrik]tekktrik left a comment (adafruit/build-mpy#19)<#19 (comment)>
Hi! Sorry this slipped by me, let me take a look over the next couple days and get back to you!
—
Reply to this email directly, view it on GitHub<#19 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAN7MKZEHR5PZK7CYJIAN732TXOM5AVCNFSM6AAAAABXEZJO76VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMJRGQYDMMZXHA>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build-mpy stopped working and compiling the CircutPython version so I made the changes indicated in #17. I removed the CircuitPython checkout and replaced it with pulling the default (current 8.0.5) version of mpy-cross. I also added the ability to specify a specific version of mpy-cross.