Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Filtering to the Roster Table #448

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

cr0wst
Copy link

@cr0wst cr0wst commented Sep 11, 2024

The existing roster page was visually nice, but I was having trouble navigating through the list. I added a panel that allows users to select filters to reduce the roster table.

Example

This adds three dropdowns and a search box to filter the roster. The Certificates dropdown is generated based on the certificates inside of the roster store.

The search box compares against the controller's name.

image image

Development

I am somewhat familiar with Vue 3 and using the composition API with script setup.

I looked around for contributing information, and I didn't see anything, so I hope this is okay. I'm happy to make any changes!

I tried to follow the method of passing refs into components instead of loading the stores and other patterns I noticed.

Testing

I tested using each of the facility files to ensure the certification options were being pulled in correctly. Things seemed to work as expected.

@cr0wst cr0wst requested a review from a team as a code owner September 11, 2024 22:42
@dhawton
Copy link
Member

dhawton commented Sep 11, 2024

Thanks.. this has been on the todo list. Do you think it'd be difficult to retain search data even if for a session (SessionStorage API)? For example, say I filter based on "steve", click on one of them to do something, and go back. I can see it handy going back to the same filtered list. I can see not retaining it between sessions so not using localStorage.

@cr0wst
Copy link
Author

cr0wst commented Sep 11, 2024

Thanks.. this has been on the todo list. Do you think it'd be difficult to retain search data even if for a session (SessionStorage API)? For example, say I filter based on "steve", click on one of them to do something, and go back. I can see it handy going back to the same filtered list. I can see not retaining it between sessions so not using localStorage.

Oh definitely, I’ll poke at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants