Drone.io global webhook signature #455
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for submitting this PR, but I'd like to discuss this feature request outside of a code review. Please open an issue to discuss this. I've not used HTTP Signatures before, so an explanation of what exactly it verifies would be helpful. For example, this PR doesn't actually validate the SHA256 hash of the payload body. Is that intentional? Do HTTP Signatures only sign/validate headers? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drone.io global webhooks use http signatures for authentication so I just added support for them using https://github.com/99designs/httpsignatures-go for the actual validation.
NB: please indulge me, I've never coded in golang before