fix: enable admin api key automatically #180
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duynguyen
reviewed
Jul 31, 2025
| } | ||
|
|
||
| // Make the POST request to update the site configuration | ||
| const postResponse = await fetch(siteConfigEndpoint, { |
Collaborator
There was a problem hiding this comment.
can we make the post to the /apiKey.json endpoint specifically, which is safer and wouldn't affect other site configs in any way?
Collaborator
Author
There was a problem hiding this comment.
We already do that to create the key, but then we need to enable it for operation, and this is done in the site config.
Collaborator
There was a problem hiding this comment.
no this is done on the access configuration, you can try /access/admin.json instead to limit the scope of the change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fix is essential, as it enables teams, partners and customers to seamlessly grant required access level to the api key generated, without requiring additonal documentation or knowledge transfer