Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Enable Modals in Header/Footer #37

Merged
merged 2 commits into from
Jan 12, 2024
Merged

feat: Enable Modals in Header/Footer #37

merged 2 commits into from
Jan 12, 2024

Conversation

andreituicu
Copy link
Collaborator

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jan 12, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jan 12, 2024 •
edited
Loading

Page Scores Audits Google
/block-collection/search PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@andreituicu andreituicu changed the title feat - Enable Modals in Header/Footer feat: Enable Modals in Header/Footer Jan 12, 2024
shsteimer
shsteimer reviewed Jan 12, 2024
View reviewed changes
scripts/scripts.js Outdated Show resolved Hide resolved
synox
synox reviewed Jan 12, 2024
View reviewed changes
blocks/header/header.css Outdated Show resolved Hide resolved
synox
synox approved these changes Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@synox synox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, I would just increase the padding

@andreituicu andreituicu merged commit 133f566 into main Jan 12, 2024
3 checks passed
@andreituicu andreituicu deleted the modal-header branch January 12, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shsteimer shsteimer shsteimer left review comments

@synox synox synox approved these changes

@davidnuescheler davidnuescheler Awaiting requested review from davidnuescheler

@fkakatie fkakatie Awaiting requested review from fkakatie

@chicharr chicharr Awaiting requested review from chicharr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreituicu @shsteimer @synox