Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate autoplay from placeholder, correct url params for embeds to w… #62

Merged
merged 1 commit into from
May 2, 2024

Conversation

shsteimer
Copy link
Collaborator

…ork with autoplay, as well as controlling for video element

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #

Test URLs:
https://video-autoplay--aem-block-collection--adobe.hlx.page/block-collection/video

…ork with autoplay, as well as controlling for video element
Copy link

aem-code-sync bot commented Apr 30, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Apr 30, 2024

Page Scores Audits Google
/block-collection/video PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@shsteimer shsteimer changed the title separate autplay from placeholder, correct url params for embeds to w… separate autoplay from placeholder, correct url params for embeds to w… Apr 30, 2024
@shsteimer shsteimer merged commit 98b7b86 into main May 2, 2024
4 checks passed
@shsteimer shsteimer deleted the video-autoplay branch May 2, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants