Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SITES-21278: Implements the logic to resolve redirect url for dispatc… #1032

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alwinjoseph02
Copy link
Collaborator

…her cache

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 11.38211% with 109 lines in your changes missing coverage. Please review.

Project coverage is 87.45%. Comparing base (f6cbd3b) to head (a90db29).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...dation/internal/InvalidateDispatcherCacheBase.java 0.00% 64 Missing ⚠️
...einvalidation/internal/InvalidateCacheSupport.java 25.80% 23 Missing ⚠️
...lidation/internal/CategoryUidsInvalidateCache.java 0.00% 8 Missing ⚠️
...alidation/internal/ProductSkusInvalidateCache.java 0.00% 8 Missing ⚠️
...dation/internal/InvalidateDispatcherCacheImpl.java 62.50% 2 Missing and 1 partial ⚠️
...invalidation/internal/InvalidateCacheRegistry.java 0.00% 2 Missing ⚠️
...cacheinvalidation/internal/HttpClientProvider.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1032      +/-   ##
============================================
- Coverage     88.83%   87.45%   -1.38%     
+ Complexity     2391     2362      -29     
============================================
  Files           366      367       +1     
  Lines         10636    10711      +75     
  Branches       1539     1547       +8     
============================================
- Hits           9448     9367      -81     
- Misses          834     1002     +168     
+ Partials        354      342      -12     
Flag Coverage Δ
integration 47.87% <0.00%> (-0.68%) ⬇️
jest 86.68% <ø> (ø)
karma 95.58% <ø> (ø)
unittests 84.76% <11.38%> (-2.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant