Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable redirect shadowing for Commerce pages in navigation component #793

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

vladbailescu
Copy link
Member

No description provided.

@herzog31 herzog31 added the bug Something isn't working label Jan 21, 2022
@codecov
Copy link

codecov bot commented Jan 21, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (055694e) 89.86% compared to head (8b7af83) 88.86%.

❗ Current head 8b7af83 differs from pull request most recent head be387a5. Consider uploading reports for the commit be387a5 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #793      +/-   ##
============================================
- Coverage     89.86%   88.86%   -1.01%     
- Complexity        0       57      +57     
============================================
  Files           171      163       -8     
  Lines          4116     3710     -406     
  Branches        617      629      +12     
============================================
- Hits           3699     3297     -402     
+ Misses          417      404      -13     
- Partials          0        9       +9     
Flag Coverage Δ
jest 86.38% <ø> (-0.31%) ⬇️
karma 95.17% <ø> (-0.37%) ⬇️
unittests 90.86% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mhaack
Copy link
Contributor

mhaack commented Feb 3, 2022

@vladbailescu how can this be tested/verified?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants