Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dollar sign in TeaserV1 action title #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

samuelgomezvaltech
Copy link

@samuelgomezvaltech samuelgomezvaltech commented Feb 21, 2022

Fixes #6

Removes output of dollar sign before action title on TeaserV1

Description

Cleanup dollar sign and create corresponding unit test

Related Issue

#6

Motivation and Context

Teaser action links output a title that does not correspond to the specification; prepending a dollar sign that, yeah, is a typo.

How Has This Been Tested?

Extended TeaserV1.tests.tsx to check for the HTML from .cmp-teaser__action-container

Ran npm run test with the original code and there is a FAIL on TeaserV1.test.tsx

Then ran again npm run test with the changed code in TeaserV1.tsx and all tests are green.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@bec40fd). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #9   +/-   ##
=========================================
  Coverage          ?   98.21%           
=========================================
  Files             ?       33           
  Lines             ?      393           
  Branches          ?       86           
=========================================
  Hits              ?      386           
  Misses            ?        7           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bec40fd...d6f08e3. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] TeaserV1 has a redundant $-sign in the action-link
1 participant