-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MOB-22791] Removal of deprecated updatePropositions overridden method & tests updates #128
base: dev-v3.3.1
Are you sure you want to change the base?
Conversation
bdd3d86
to
08ad7ca
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-v3.3.1 #128 +/- ##
=============================================
Coverage ? 82.44%
Complexity ? 226
=============================================
Files ? 9
Lines ? 1116
Branches ? 180
=============================================
Hits ? 920
Misses ? 114
Partials ? 82
Flags with carried forward coverage won't be shown. Click here to find out more.
|
9fb5042
to
c5bb2b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't remove public APIs unless its a major version release to ensure backwards compatibility in minor version updates. It happens once a year and is coordinated across all extensions. Please hold off on this till then and reach out to Praveen (Core squad) to see if we have one planned anytime soon.
Yeah @spoorthipujariadobe we'll merge this PR only when we'll release the major version bump, I already requested for the updates on the same from Praveen. |
…interface 2. Moved the existing tests calls to update and get propositions internal methods 3. Changed signature of of get and update propositions internal from private to package-private and made Visible for testing
c5bb2b2
to
dbbd594
Compare
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: