Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOB-22791] Removal of deprecated updatePropositions overridden method & tests updates #128

Open
wants to merge 4 commits into
base: dev-v3.3.1
Choose a base branch
from

Conversation

siddique-adobe
Copy link
Contributor

@siddique-adobe siddique-adobe commented Jan 27, 2025

Description

  1. We've marked updateProposition without callback method deprecated in our last release
  2. We'll be removing and merging the same in the upcoming major version release of target

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (dev-v3.3.1@e366af5). Learn more about missing BASE report.

Additional details and impacted files
@@              Coverage Diff              @@
##             dev-v3.3.1     #128   +/-   ##
=============================================
  Coverage              ?   82.44%           
  Complexity            ?      226           
=============================================
  Files                 ?        9           
  Lines                 ?     1116           
  Branches              ?      180           
=============================================
  Hits                  ?      920           
  Misses                ?      114           
  Partials              ?       82           
Flag Coverage Δ
android-functional-tests 52.96% <ø> (?)
android-unit-tests 80.38% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../com/adobe/marketing/mobile/optimize/Optimize.java 70.43% <ø> (ø)

Copy link
Contributor

@spoorthipujariadobe spoorthipujariadobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't remove public APIs unless its a major version release to ensure backwards compatibility in minor version updates. It happens once a year and is coordinated across all extensions. Please hold off on this till then and reach out to Praveen (Core squad) to see if we have one planned anytime soon.

@siddique-adobe
Copy link
Contributor Author

We don't remove public APIs unless its a major version release to ensure backwards compatibility in minor version updates. It happens once a year and is coordinated across all extensions. Please hold off on this till then and reach out to Praveen (Core squad) to see if we have one planned anytime soon.

Yeah @spoorthipujariadobe we'll merge this PR only when we'll release the major version bump, I already requested for the updates on the same from Praveen.

@siddique-adobe siddique-adobe changed the base branch from dev-v3.2.3 to dev-v3.3.1 February 17, 2025 11:09
ishwetansh and others added 4 commits February 18, 2025 02:31
…interface

 2. Moved the existing tests calls to update and get propositions internal methods
 3. Changed signature of of get and update propositions internal from private to package-private and made Visible for testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants