fix: processing and assigning an action's annotations when there are …

…none (#198)
adobe · Dec 17, 2024 · ea597e5 · ea597e5
1 parent 827baba
commit ea597e5
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 1 deletion.
diff --git a/src/utils.js b/src/utils.js
@@ -1102,7 +1102,9 @@ function rewriteActionsWithAdobeAuthAnnotation (packages, deploymentPackages) {
     if (newPackages[key].actions) {
       Object.keys(newPackages[key].actions).forEach((actionName) => {
         const thisAction = newPackages[key].actions[actionName]
-        Object.assign(thisAction.annotations, processAnnotationsForWebAction(thisAction))
+        if (thisAction.annotations) {
+          Object.assign(thisAction.annotations, processAnnotationsForWebAction(thisAction))
+        }
         const isWeb = thisAction.annotations?.[ANNOTATION_WEB_EXPORT]
         const isRaw = thisAction.annotations?.[ANNOTATION_RAW_HTTP]
 

diff --git a/test/utils.test.js b/test/utils.test.js
@@ -1118,6 +1118,36 @@ describe('processPackage', () => {
     spy.mockRestore()
   })
 
+  test('1 action with no annotations', () => {
+    const spy = jest.spyOn(fs, 'readFileSync')
+    const fakeCode = 'fake action code'
+    spy.mockImplementation(() => fakeCode)
+    const deploymentPackages = { pkg1: { actions: { theaction: { inputs: { a: 34 } } } } }
+
+    const basicPackageNoAnnotations = structuredClone(basicPackage)
+    delete basicPackageNoAnnotations.pkg1.actions.theaction.annotations
+
+    const res = utils.processPackage(basicPackageNoAnnotations, deploymentPackages, {}, {}, false, { apihost: 'https://adobeioruntime.net' })
+    expect(res).toEqual({
+      actions: [
+        {
+          name: 'pkg1/theaction',
+          action: fakeCode,
+          params: { a: 34 },
+          annotations: {
+            'web-export': true,
+            'raw-http': false
+          }
+        }
+      ],
+      apis: [],
+      pkgAndDeps: [{ name: 'pkg1' }],
+      rules: [],
+      triggers: []
+    })
+    spy.mockRestore()
+  })
+
   test('action using the annotation + rewrite deployment package => action has empty imputs', () => {
     const spy = jest.spyOn(fs, 'readFileSync')
     const fakeCode = 'fake action code'