Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ACNA-3239 - hash dependencies not in node_modules #196

Merged
merged 4 commits into from
Jan 14, 2025
Merged

Conversation

purplecabbage
Copy link
Member

@purplecabbage purplecabbage commented Oct 18, 2024

Description

This pr adds dependent files to the hash it generates during build. Note that these files are still not watched, but if they change between run/dev/build it is detected.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ea597e5) to head (088bd08).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #196   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines         1326      1338   +12     
  Branches       346       346           
=========================================
+ Hits          1326      1338   +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shazron shazron changed the title hash dependencies not in node_modules fix: ACNA-3239 - hash dependencies not in node_modules Jan 14, 2025
@shazron shazron merged commit b4350e7 into master Jan 14, 2025
10 checks passed
@shazron shazron deleted the ACNA-3239 branch January 14, 2025 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants