Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add okta MFA support for vault auth #170

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Add okta MFA support for vault auth #170

merged 2 commits into from
Jan 14, 2025

Conversation

asalajan
Copy link
Contributor

Description

Add okta MFA support for vault auth

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@pep8speaks
Copy link

pep8speaks commented Jan 13, 2025 •
edited
Loading

Hello @asalajan! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2025-01-14 07:58:27 UTC

StefanDinu
StefanDinu approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@StefanDinu StefanDinu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :+1

@asalajan asalajan merged commit f446dd7 into adobe:master Jan 14, 2025
4 checks passed
@asalajan asalajan deleted the okta branch January 14, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefangusa stefangusa stefangusa approved these changes

@StefanDinu StefanDinu StefanDinu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asalajan @pep8speaks @stefangusa @StefanDinu