fix: table resizing click stuck#10040
Merged
Merged
Conversation
|
Build successful! 🎉 |
LFDanLu
reviewed
May 12, 2026
Comment on lines
+297
to
+301
| }, | ||
| onPressEnd: () => { | ||
| if (state.resizingColumn != null) { | ||
| endResize(item); | ||
| } |
Member
There was a problem hiding this comment.
One thing I noticed is that the resizing "divider" line now disappears as you drag the handle on mobile, doesn't seem to happen on main. Note that it doesn't cancel the resize event, it is only that the divider disappears
Member
Author
There was a problem hiding this comment.
hmmm yeah, i am not 100% on this approach yet. But I hadn't found any bad behaviours yet, thanks for finding that. I'll revisit the approach again.
Member
There was a problem hiding this comment.
lemme know if you need help investigating, I tested on Android.
Member
Author
There was a problem hiding this comment.
thanks, I'll let you know how i go tomorrow
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
LFDanLu
approved these changes
Jun 26, 2026
devongovett
approved these changes
Jun 26, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
|
Build successful! 🎉 |
## API Changes
@react-aria/table/@react-aria/table:TableColumnResizeAria TableColumnResizeAria {
inputProps: DOMAttributes
+ isMouseResizing: boolean
isResizing: boolean
resizerProps: DOMAttributes
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10032
What happened was that the cursor overlay we use to style the cursor with the e-w arrows against the entire screen was receiving the pointer events after it appeared in press start. This caused us to be stuck in the resizer mode because
onPresswas never called.Now we delay until there is an actual movement before we show the cursor style overlay. This is fine because usually the cursor styles are already on the draggable item to indicate it can drag. After that, we only care to keep showing it globally so long as it's still being dragged and the mouse has gone off somewhere else. This doesn't affect other modalities.
✅ Pull Request Checklist:
📝 Test Instructions:
Go to path=/story/react-aria-components-table--table-example-story or docs build from this PR react-aria.adobe.com/Table#column-resizing and click on a column resizer. It should not get stuck with the focus indication showing that we're actively in resize mode.
🧢 Your Project: