-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Tableview crash bug #5380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tableview crash bug #5380
Conversation
Build successful! 🎉 |
Note about the wrapping the following updateSize in RAFs: it resolves the crashes in both TableView and CardView but infinite resize loops can still occur. They don't crash the components but they are visible as constant flickering at specific breakpoints unique to each setup. Tests and lint run clean |
Build successful! 🎉 |
We've broken header in Tables, they no longer scroll with the body. |
Build successful! 🎉 |
Build successful! 🎉 |
I'd rather not add a new property to LayoutInfo. Instead, I think we can make the header have an inner div with the content size so it matches how ScrollView works. |
This reverts commit b4104f8.
Build successful! 🎉 |
@@ -655,7 +656,14 @@ function TableVirtualizer(props) { | |||
transition: state.isAnimating ? `none ${state.virtualizer.transitionDuration}ms` : undefined | |||
}} | |||
ref={headerRef}> | |||
{state.visibleViews[0]} | |||
<div |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clever 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following stories now crash with the 185 error:
https://reactspectrum.blob.core.windows.net/reactspectrum/14a4cd3d812ae383add4677d7f50e1c15096664a/storybook/index.html?path=/story/tableview--typeahead-with-dialog&providerSwitcher-express=false
https://reactspectrum.blob.core.windows.net/reactspectrum/14a4cd3d812ae383add4677d7f50e1c15096664a/storybook/index.html?path=/story/tableview--links&providerSwitcher-express=false
https://reactspectrum.blob.core.windows.net/reactspectrum/14a4cd3d812ae383add4677d7f50e1c15096664a/storybook/index.html?path=/story/tableview--column-header-focus-ring-table&providerSwitcher-express=false
Only started happening once we changed to using the 100% width method, I don't really see any common pattern between those three at a glance, in fact the "column header focus after loading" seems pretty straightforward and has a set height...
Happy to approve if we still want to get a nightly for this
Oo, those all crash instantly, i don't think we want to introduce that |
c96a5f3
Build successful! 🎉 |
## API Changes
unknown top level export { type: 'any' } |
Might be related to #5357
Some observations:
✅ Pull Request Checklist:
📝 Test Instructions:
Title
column by clicking on itTitle
a couple times to get it to work. See if you notice any difference with Strictmode on or off.Note: It is a bit finicky but both Rob and I have been able to reproduce it at this width and zoom pretty consistently.
🧢 Your Project: