Skip to content

Comments

fix: Vertical TabList Wrapping#8201

Merged
snowystinger merged 6 commits intoadobe:mainfrom
bsmiley1:fix/XI-7052-vertical-tablist-wrapping
Jul 15, 2025
Merged

fix: Vertical TabList Wrapping#8201
snowystinger merged 6 commits intoadobe:mainfrom
bsmiley1:fix/XI-7052-vertical-tablist-wrapping

Conversation

@bsmiley1
Copy link
Contributor

@bsmiley1 bsmiley1 commented May 7, 2025

Closes

#2567

Please see Spectrum Design Documentation for guidance on wrapping within tab items.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Please see use the Orientation Vertical Wrap storybook for testing.

🧢 Your Project:

This fix has been requested by Adobe GenStudio's General Manager.

image

@bsmiley1 bsmiley1 force-pushed the fix/XI-7052-vertical-tablist-wrapping branch from d9b3e79 to 8c2fad4 Compare May 7, 2025 21:53
@bsmiley1 bsmiley1 changed the title Fix/xi 7052 vertical tablist wrapping fix: XI-7052 vertical tablist wrapping May 7, 2025
@bsmiley1 bsmiley1 changed the title fix: XI-7052 vertical tablist wrapping fix: Vertical TabList Wrapping May 7, 2025
Copy link
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, we're just checking with Spectrum Design on intent/history here since it exists as a screenshot of a side navigation. So it might be the wrong screen shot, or at the very least, unintended. (it has a label above the items)
It is also not specified as a behaviour on the page explicitly, nor in the XD file.

@snowystinger
Copy link
Member

Update: We'll proceed with reviewing. Thanks for the PR, hopefully we'll get time to test it soon.

snowystinger
snowystinger previously approved these changes Jun 23, 2025
@snowystinger snowystinger enabled auto-merge July 15, 2025 00:23
@snowystinger snowystinger added this pull request to the merge queue Jul 15, 2025
Merged via the queue into adobe:main with commit 488bb6b Jul 15, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants