chore: Lockfiles for all apps#8940
Merged
Merged
Conversation
This reverts commit 5bff9d5.
snowystinger
commented
Sep 29, 2025
|
|
||
| starter: | ||
| cd starters/docs && yarn --no-immutable && yarn tsc | ||
| cd starters/docs && yarn --no-immutable && yarn up react-aria-components && yarn tsc |
Member
Author
There was a problem hiding this comment.
this forces the update from the version provided by the root workspace, to the latest tag on verdaccio. I'm not sure why there is no way to override this yarn behaviour and not look at the root workspace at all, but this appears to be the case currently. I think due to yarnpkg/yarn#4099
|
Build successful! 🎉 |
|
Build successful! 🎉 |
LFDanLu
reviewed
Oct 2, 2025
|
Build successful! 🎉 |
This reverts commit 37e6c89.
|
Build successful! 🎉 |
This reverts commit ca2faf9.
|
Build successful! 🎉 |
LFDanLu
previously approved these changes
Oct 8, 2025
LFDanLu
left a comment
LFDanLu
left a comment
Member
There was a problem hiding this comment.
Verified that the proper bumped version is being published via verdaccio, will double check the installed lockfile when I get back home/tmrw but should be fine
This reverts commit 622ad5e.
|
Build successful! 🎉 |
LFDanLu
approved these changes
Oct 8, 2025
reidbarber
approved these changes
Oct 8, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
|
Build successful! 🎉 |
devongovett
pushed a commit
that referenced
this pull request
Oct 9, 2025
* chore: lockfile for all apps * turn on verdaccio * set hoisting limit * build starters outside root workspace * fix indentation * force dependency update to latest * try another command * try yet another command * fix paths * fix more paths * reduce complexity and force upgrade locally * Revert "turn on verdaccio" This reverts commit 5bff9d5. * force update all versions in all example apps * turn on verdaccio * fix webpack 4 app * fix icon builder * try cache cleaning * force npx to use local verdaccio registry * try another method of forcing the registry * specify a specific version for the tool * debugging * remove debug statement * Revert "turn on verdaccio" This reverts commit 37e6c89. * turn on verdaccio * Revert "turn on verdaccio" This reverts commit ca2faf9. * turn on verdaccio * add debugging * one more debug line * Revert "turn on verdaccio" This reverts commit 622ad5e.
bsmiley1
pushed a commit
to bsmiley1/react-spectrum
that referenced
this pull request
Dec 5, 2025
* chore: lockfile for all apps * turn on verdaccio * set hoisting limit * build starters outside root workspace * fix indentation * force dependency update to latest * try another command * try yet another command * fix paths * fix more paths * reduce complexity and force upgrade locally * Revert "turn on verdaccio" This reverts commit 5bff9d5. * force update all versions in all example apps * turn on verdaccio * fix webpack 4 app * fix icon builder * try cache cleaning * force npx to use local verdaccio registry * try another method of forcing the registry * specify a specific version for the tool * debugging * remove debug statement * Revert "turn on verdaccio" This reverts commit 37e6c89. * turn on verdaccio * Revert "turn on verdaccio" This reverts commit ca2faf9. * turn on verdaccio * add debugging * one more debug line * Revert "turn on verdaccio" This reverts commit 622ad5e.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
Split out from #8913
This just focuses on lock files and install states for all of our examples and starters. It's the first PR because it's probably the most important to establish. From here we can see what future changes are actually doing and something new can't come in and cause a different issue. Think of it as establishing a baseline.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: