fix: nightly packing too many files#9917
Merged
devongovett merged 1 commit intomainfrom Apr 13, 2026
Merged
Conversation
reidbarber
approved these changes
Apr 13, 2026
devongovett
approved these changes
Apr 13, 2026
Member
devongovett
left a comment
There was a problem hiding this comment.
Seems right. Not sure if we are going to have to publish src/exports for tsdiff. I was hoping not since it inflates the package size quite a bit. Maybe we can consider diffing based on a past git commit instead of npm?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
I found that yarn uses micromatch, https://github.com/yarnpkg/berry/blob/master/packages/plugin-pack/sources/packUtils.ts which will treat a pattern like
!storiesas literally just exclude thestoriesfile, it doesn't match as a directory likenpmorgitignorewill.We can test it here https://codesandbox.io/p/devbox/6wzks8
npm will however still work with the glob syntax, so doing it more explicitly as in this PR should work for both tools.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: