Skip to content

fix: nightly packing too many files#9917

Merged
devongovett merged 1 commit intomainfrom
fix-nightly-publishing
Apr 13, 2026
Merged

fix: nightly packing too many files#9917
devongovett merged 1 commit intomainfrom
fix-nightly-publishing

Conversation

@snowystinger
Copy link
Copy Markdown
Member

Closes

I found that yarn uses micromatch, https://github.com/yarnpkg/berry/blob/master/packages/plugin-pack/sources/packUtils.ts which will treat a pattern like !stories as literally just exclude the stories file, it doesn't match as a directory like npm or gitignore will.
We can test it here https://codesandbox.io/p/devbox/6wzks8

npm will however still work with the glob syntax, so doing it more explicitly as in this PR should work for both tools.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@github-actions github-actions Bot added the RAC label Apr 13, 2026
Copy link
Copy Markdown
Member

@devongovett devongovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems right. Not sure if we are going to have to publish src/exports for tsdiff. I was hoping not since it inflates the package size quite a bit. Maybe we can consider diffing based on a past git commit instead of npm?

@devongovett devongovett added this pull request to the merge queue Apr 13, 2026
Merged via the queue into main with commit efc581c Apr 13, 2026
29 checks passed
@devongovett devongovett deleted the fix-nightly-publishing branch April 13, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants