fix: access right subproperty

adobe · Feb 24, 2025 · 0a8e4a0 · 0a8e4a0
1 parent dbc7f6c
commit 0a8e4a0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/image-alt-text/opportunityHandler.js b/src/image-alt-text/opportunityHandler.js
@@ -30,7 +30,7 @@ export async function syncAltTextSuggestions({ opportunity, newSuggestions, log
 
   // eslint-disable-next-line max-len
   const ignoredSuggestions = existingSuggestions.filter((s) => s.status === SuggestionModel.STATUSES.SKIPPED);
-  const ignoredSuggestionIds = ignoredSuggestions.map((s) => s.id);
+  const ignoredSuggestionIds = ignoredSuggestions.map((s) => s.data.recommendations[0].id);
 
   // Remove existing suggestions that were not ignored
   await Promise.all(existingSuggestions

diff --git a/test/audits/image-alt-text/opportunity-handler.test.js b/test/audits/image-alt-text/opportunity-handler.test.js
@@ -212,16 +212,18 @@ describe('Image Alt Text Opportunity Handler', () => {
   it('should preserve ignored suggestions when syncing', async () => {
     dataAccessStub.Opportunity.allBySiteIdAndStatus.resolves([altTextOppty]);
 
-    // Mock existing suggestions with one ignored
+    // Mock existing suggestions with one ignored - update to include data.id
     const mockSuggestions = [
       {
         id: 'suggestion-1',
         status: SuggestionModel.STATUSES.SKIPPED,
+        data: { recommendations: [{ id: 'suggestion-1' }] }, // Add data.id to match handler's expectation
         remove: sinon.stub().resolves(),
       },
       {
         id: 'suggestion-2',
         status: 'NEW',
+        data: { recommendations: [{ id: 'suggestion-2' }] }, // Add data.id to match handler's expectation
         remove: sinon.stub().resolves(),
       },
     ];