fix: access right subproperty

adobe · Feb 24, 2025 · 5543f44 · 5543f44
1 parent dbc7f6c
commit 5543f44
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/src/image-alt-text/opportunityHandler.js b/src/image-alt-text/opportunityHandler.js
@@ -29,8 +29,8 @@ export async function syncAltTextSuggestions({ opportunity, newSuggestions, log
   const existingSuggestions = await opportunity.getSuggestions();
 
   // eslint-disable-next-line max-len
-  const ignoredSuggestions = existingSuggestions.filter((s) => s.status === SuggestionModel.STATUSES.SKIPPED);
-  const ignoredSuggestionIds = ignoredSuggestions.map((s) => s.id);
+  const ignoredSuggestions = existingSuggestions.filter((s) => s.getStatus() === SuggestionModel.STATUSES.SKIPPED);
+  const ignoredSuggestionIds = ignoredSuggestions.map((s) => s.getData().recommendations[0].id);
 
   // Remove existing suggestions that were not ignored
   await Promise.all(existingSuggestions

diff --git a/test/audits/image-alt-text/opportunity-handler.test.js b/test/audits/image-alt-text/opportunity-handler.test.js
@@ -33,6 +33,7 @@ describe('Image Alt Text Opportunity Handler', () => {
       save: sinon.stub(),
       getSuggestions: sinon.stub().returns([{
         id: 'suggestion-1',
+        getStatus: () => 'NEW',
         status: 'NEW',
         remove: sinon.stub().resolves(),
       }]),
@@ -216,12 +217,16 @@ describe('Image Alt Text Opportunity Handler', () => {
     const mockSuggestions = [
       {
         id: 'suggestion-1',
+        getStatus: () => SuggestionModel.STATUSES.SKIPPED,
         status: SuggestionModel.STATUSES.SKIPPED,
+        getData: () => ({ recommendations: [{ id: 'suggestion-1' }] }),
         remove: sinon.stub().resolves(),
       },
       {
         id: 'suggestion-2',
+        getStatus: () => 'NEW',
         status: 'NEW',
+        getData: () => ({ recommendations: [{ id: 'suggestion-2' }] }),
         remove: sinon.stub().resolves(),
       },
     ];