feat: updating the interval for rum query #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR will trigger a minor release when merged. |
vdua
reviewed
Feb 4, 2025
| @@ -15,8 +15,8 @@ import { getRUMDomainkey } from '../support/utils.js'; | |||
| import { AuditBuilder } from '../common/audit-builder.js'; | |||
| import { wwwUrlResolver } from '../common/audit.js'; | |||
|
|
|||
| const DAILY_THRESHOLD = 200; | |||
| const INTERVAL = 7; // days | |||
| const DAILY_THRESHOLD = 0; | |||
There was a problem hiding this comment.
any reason for setting the daily threshold to 0 ?
There was a problem hiding this comment.
@05rahulsingh , i think we should keep this threshold of 200
its just that we should not apply this threshold on form pages but only on the pages having the form CTA for the form oppty: high page views, low form ctr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ensure your pull request adheres to the following guidelines:
Related Issues
Thanks for contributing!