feat: adding new forms opportunity and sending urls for scraping #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nit23uec
reviewed
Feb 13, 2025
| siteId: auditData.siteId, | ||
| auditId: auditData.id, | ||
| runbook: 'https://adobe.sharepoint.com/:w:/s/AEM_Forms/EU_cqrV92jNIlz8q9gxGaOMBSRbcwT9FPpQX84bRKQ9Phw?e=Nw9ZRz', | ||
| type: 'high-page-views-low-form-cta', |
nit23uec
reviewed
Feb 13, 2025
| type: 'high-page-views-low-form-cta', | ||
| origin: 'AUTOMATION', | ||
| title: 'Form has low views but CTA page has high views', | ||
| description: 'Form has low views but CTA page has high view', |
There was a problem hiding this comment.
We should rewrite desc as
The page containing the form CTA has high views but low CTR for the form CTA
nit23uec
reviewed
Feb 13, 2025
| runbook: 'https://adobe.sharepoint.com/:w:/s/AEM_Forms/EU_cqrV92jNIlz8q9gxGaOMBSRbcwT9FPpQX84bRKQ9Phw?e=Nw9ZRz', | ||
| type: 'high-page-views-low-form-cta', | ||
| origin: 'AUTOMATION', | ||
| title: 'Form has low views but CTA page has high views', |
There was a problem hiding this comment.
But conversion element has low CTR
nit23uec
reviewed
Feb 13, 2025
| log.info(`Triggering scrape for [${JSON.stringify(uniqueUrls, null, 2)}]`); | ||
| if (uniqueUrls.size > 0) { | ||
| await sqs.sendMessage(process.env.SCRAPING_JOBS_QUEUE_URL, { | ||
| processingType: 'default', |
nit23uec
reviewed
Feb 13, 2025
| } | ||
|
|
||
| const { formVitals } = auditData.auditResult; | ||
| const formOpportunities = generateOpptyDataForHighPageViewsLowFormCTA(formVitals); |
nit23uec
reviewed
Feb 13, 2025
| * @param auditData - The audit data containing the audit result and additional details. | ||
| * @param context - The context object containing the data access and logger objects. | ||
| */ | ||
| export default async function highPageViewsLowFormCTAOpportunity(auditUrl, auditData, context) { |
nit23uec
reviewed
Feb 13, 2025
| export default async function highPageViewsLowFormCTAOpportunity(auditUrl, auditData, context) { | ||
| const { dataAccess, log } = context; | ||
| const { Opportunity } = dataAccess; | ||
| log.info(`Syncing high page views low form cta opportunity for ${auditData.siteId}`); |
nit23uec
reviewed
Feb 13, 2025
|
|
||
| try { | ||
| const opportunities = await Opportunity.allBySiteIdAndStatus(auditData.siteId, 'NEW'); | ||
| highPageViewsLowFormCtaOppty = opportunities.find((oppty) => oppty.getType() === 'high-page-views-low-form-cta'); |
nit23uec
reviewed
Feb 13, 2025
| const opportunityData = { | ||
| siteId: auditData.siteId, | ||
| auditId: auditData.id, | ||
| runbook: 'https://adobe.sharepoint.com/:w:/s/AEM_Forms/EU_cqrV92jNIlz8q9gxGaOMBSRbcwT9FPpQX84bRKQ9Phw?e=Nw9ZRz', |
There was a problem hiding this comment.
Can you pls create a unique runbook for this besides the existing one
There was a problem hiding this comment.
nit23uec
reviewed
Feb 13, 2025
|
|
||
| const uniqueUrls = new Set(); | ||
| formOpportunities.forEach((opptyData) => { | ||
| uniqueUrls.add(opptyData.url); |
There was a problem hiding this comment.
This url should be of the page containing CTA
nit23uec
reviewed
Feb 13, 2025
src/forms-opportunities/utils.js
Outdated
| ); | ||
|
|
||
| // const formVitalsByDevice = aggregateFormVitalsByDevice(formVitalsCollection); | ||
| return getHighPageViewsLowFormCtrMetrics(formVitalsCollection, 7).map(convertToOpportunityData); |
There was a problem hiding this comment.
Oppoty data would need some changes for this oppoty type.
CtaPageUrl
MaxCTR
formCTR
There was a problem hiding this comment.
oppty data for high page views low form ctr has
{
url: 'https://www.surest.com/newsletter',
pageViews: 8670,
formViews: 300,
formEngagement: 300,
CTA: {
url: 'https://www.surest.com/about-us',
source: '#teaser-related02 .cmp-teaser__action-link',
},
}
|
This PR will trigger a minor release when merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ensure your pull request adheres to the following guidelines:
Related Issues
Thanks for contributing!