-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(stepper): border focus hover color #3558
base: marissahuysentruyt/css-1112-background-color-form-elements-fix
Are you sure you want to change the base?
fix(stepper): border focus hover color #3558
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: remove these commented properties.
File metricsSummaryTotal size: 2.25 MB*
File change detailsinfieldbutton
picker
stepper
* An ASCII character in UTF-8 is 8 bits or 1 byte. |
89ab810
to
408ed9a
Compare
6ac2359
to
9632409
Compare
408ed9a
to
a09845c
Compare
- fixes the focus & focus hover states, so that hovering over either element (the textfield OR the stepper buttons) will trigger the SAME border color for both elements. - removed some of the :not(disabled) to simplify selectors. - add keyboardfocused+hovered test - keyboardfocused+hovered states showcase hovering over any part of the element triggers the SAME border color for the textfield and the infield buttons - metadata updated and removal of code/TODO comments
9632409
to
f09bfc4
Compare
Description
During #3536, we found that the stepper had more bugs particularly in dark mode, and particularly when you hovered over other states, like focus or keyboard-focus. This PR should revamp the CSS so that the stepper states are triggered in the expected way, where hovering over any of the nested subcomponents triggers the correct border color changes to all subcomponents. As an example, hovering over the stepper buttons should trigger a border color change in the stepper buttons, AS WELL AS trigger the border color on the stepper textfield.
Jira/Specs
CSS-1127
Also related to CSS-1112
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
Regression testing
Validate:
Screenshots
Before 🚫



After ✅
To-do list