Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stepper): border focus hover color #3558

Open
wants to merge 2 commits into
base: marissahuysentruyt/css-1112-background-color-form-elements-fix
Choose a base branch
from

Conversation

marissahuysentruyt
Copy link
Collaborator

@marissahuysentruyt marissahuysentruyt commented Feb 14, 2025

Description

During #3536, we found that the stepper had more bugs particularly in dark mode, and particularly when you hovered over other states, like focus or keyboard-focus. This PR should revamp the CSS so that the stepper states are triggered in the expected way, where hovering over any of the nested subcomponents triggers the correct border color changes to all subcomponents. As an example, hovering over the stepper buttons should trigger a border color change in the stepper buttons, AS WELL AS trigger the border color on the stepper textfield.

Jira/Specs

CSS-1127
Also related to CSS-1112

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • VRTs have been run and looked at.
  • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

Before 🚫
Screenshot 2025-02-14 at 4 40 21 PM
Screenshot 2025-02-14 at 4 40 06 PM
Screenshot 2025-02-14 at 4 38 12 PM

After ✅

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

Copy link

changeset-bot bot commented Feb 14, 2025

⚠️ No Changeset found

Latest commit: f09bfc4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@marissahuysentruyt marissahuysentruyt self-assigned this Feb 14, 2025
@marissahuysentruyt marissahuysentruyt added the wip This is a work in progress, don't judge. label Feb 14, 2025
@marissahuysentruyt marissahuysentruyt changed the base branch from main to marissahuysentruyt/css-1112-background-color-form-elements-fix February 14, 2025 21:22
Copy link
Collaborator Author

@marissahuysentruyt marissahuysentruyt Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: remove these commented properties.

Copy link
Contributor

File metrics

Summary

Total size: 2.25 MB*
No change in file sizes

Package Size Minified Gzipped
infieldbutton 15.55 KB 14.97 KB 1.87 KB
picker 28.12 KB 26.85 KB 3.38 KB
stepper 18.87 KB 17.99 KB 2.33 KB

File change details

infieldbutton

Filename Head Minified Gzipped Compared to base
index-base.css 14.77 KB 14.22 KB 1.78 KB -
index-theme.css 1.65 KB 1.61 KB 0.57 KB -
index.css 15.55 KB 14.97 KB 1.87 KB 🔴 ⬆ < 0.01 KB
metadata.json 7.74 KB - - 🟢 ⬇ 0.03 KB
themes/express.css 1.37 KB 1.33 KB 0.57 KB -
themes/spectrum-two.css 1.38 KB 1.35 KB 0.57 KB 🔴 ⬆ < 0.01 KB
themes/spectrum.css 1.39 KB 1.36 KB 0.58 KB -

picker

Filename Head Minified Gzipped Compared to base
index-base.css 27.17 KB 25.94 KB 3.30 KB 🔴 ⬆ < 0.01 KB
index-theme.css 1.84 KB 1.80 KB 0.57 KB -
index.css 28.12 KB 26.85 KB 3.38 KB 🔴 ⬆ < 0.01 KB
metadata.json 14.89 KB - - 🟢 ⬇ 0.03 KB
themes/express.css 1.45 KB 1.41 KB 0.55 KB -
themes/spectrum-two.css 1.55 KB 1.51 KB 0.56 KB -
themes/spectrum.css 1.56 KB 1.51 KB 0.57 KB -

stepper

Filename Head Minified Gzipped Compared to base
index-base.css 17.58 KB 16.75 KB 2.22 KB 🔴 ⬆ 0.94 KB
index-theme.css 2.86 KB 2.79 KB 0.66 KB 🔴 ⬆ 0.10 KB
index.css 18.87 KB 17.99 KB 2.33 KB 🔴 ⬆ 0.55 KB
metadata.json 9.21 KB - - 🔴 ⬆ 0.28 KB
themes/express.css 2.15 KB 2.07 KB 0.66 KB 🔴 ⬆ 0.09 KB
themes/spectrum-two.css 1.86 KB 1.81 KB 0.61 KB 🟢 ⬇ 0.37 KB
themes/spectrum.css 1.94 KB 1.88 KB 0.62 KB 🟢 ⬇ 0.30 KB
* Size is the sum of all main files for packages in the library.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@marissahuysentruyt marissahuysentruyt force-pushed the marissahuysentruyt/css-1112-background-color-form-elements-fix branch from 89ab810 to 408ed9a Compare February 18, 2025 20:19
@marissahuysentruyt marissahuysentruyt force-pushed the marissahuysentruyt/fix-stepper-border-focus-hover-color branch from 6ac2359 to 9632409 Compare February 18, 2025 20:23
@marissahuysentruyt marissahuysentruyt changed the title Marissahuysentruyt/fix stepper border focus hover color fix(stepper): border focus hover color Feb 18, 2025
@marissahuysentruyt marissahuysentruyt marked this pull request as ready for review February 18, 2025 20:25
@marissahuysentruyt marissahuysentruyt force-pushed the marissahuysentruyt/css-1112-background-color-form-elements-fix branch from 408ed9a to a09845c Compare February 18, 2025 21:02
- fixes the focus & focus hover states, so that hovering over either
element (the textfield OR the stepper buttons) will trigger the SAME
border color for both elements.
- removed some of the :not(disabled) to simplify selectors.
- add keyboardfocused+hovered test
- keyboardfocused+hovered states showcase hovering over any part of the
element triggers the SAME border color for the textfield and the infield
buttons
- metadata updated and removal of code/TODO comments
@marissahuysentruyt marissahuysentruyt force-pushed the marissahuysentruyt/fix-stepper-border-focus-hover-color branch from 9632409 to f09bfc4 Compare February 18, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wip This is a work in progress, don't judge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant