Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(picker): updated background-color and border-color #3572

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

blunteshwar
Copy link

@blunteshwar blunteshwar commented Feb 24, 2025

Description

Updated backgroud-color and border-color tokens for picker.
https://jira.corp.adobe.com/browse/SWC-641

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • VRTs have been run and looked at.
  • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

Copy link

changeset-bot bot commented Feb 24, 2025

⚠️ No Changeset found

Latest commit: 4de7b87

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 24, 2025

File metrics

Summary

Total size: 2.25 MB*

Package Size Minified Gzipped
picker 28.11 KB 26.84 KB 3.38 KB

picker

Filename Head Minified Gzipped Compared to base
index-base.css 27.17 KB 25.94 KB 3.30 KB -
index-theme.css 1.84 KB 1.80 KB 0.57 KB -
index.css 28.11 KB 26.84 KB 3.38 KB 🟢 ⬇ 0.01 KB
metadata.json 14.89 KB - - 🟢 ⬇ 0.03 KB
themes/express.css 1.45 KB 1.41 KB 0.55 KB -
themes/spectrum-two.css 1.54 KB 1.49 KB 0.56 KB 🟢 ⬇ 0.01 KB
themes/spectrum.css 1.56 KB 1.51 KB 0.57 KB -
* Size is the sum of all main files for packages in the library.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

Copy link
Contributor

github-actions bot commented Feb 24, 2025

🚀 Deployed on https://pr-3572--spectrum-css.netlify.app

@blunteshwar blunteshwar added S2 Spectrum 2 fast-follows An issue or PR that quickly follows a release labels Feb 24, 2025
@@ -1,5 +1,6 @@
dist
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be updated as part of the picker PR, please feel free to open a separate PR to address any concerns with the .gitignore

@castastrophe castastrophe added size-2 S ~6-18hrs; not hard or time consuming, one or two work days to complete. ready-for-review high priority An important PR or issue requiring immediate attention labels Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-follows An issue or PR that quickly follows a release high priority An important PR or issue requiring immediate attention ready-for-review S2 Spectrum 2 size-2 S ~6-18hrs; not hard or time consuming, one or two work days to complete.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants