Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(checkbox): s2 foundation updated deseclected border #3574

Closed
wants to merge 1 commit into from

Conversation

Rajdeepc
Copy link
Collaborator

Description

Updated in spectrum-two

--system-checkbox-control-color-default: var(--spectrum-neutral-content-color-default);

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • VRTs have been run and looked at.
  • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

Copy link

changeset-bot bot commented Feb 24, 2025

⚠️ No Changeset found

Latest commit: 18a04e9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rajdeepc Rajdeepc self-assigned this Feb 24, 2025
@Rajdeepc
Copy link
Collaborator Author

Fixed by #3573

@Rajdeepc Rajdeepc closed this Feb 24, 2025
Copy link
Contributor

File metrics

Summary

Total size: 2.25 MB*

Package Size Minified Gzipped
checkbox 22.43 KB 21.35 KB 2.56 KB

checkbox

Filename Head Minified Gzipped Compared to base
index-base.css 22.03 KB 20.97 KB 2.52 KB -
index-theme.css 1.14 KB 1.12 KB 0.51 KB -
index.css 22.43 KB 21.35 KB 2.56 KB 🔴 ⬆ 0.02 KB
metadata.json 12.69 KB - - 🟢 ⬇ 0.03 KB
themes/express.css 1.04 KB 1.01 KB 0.51 KB -
themes/spectrum-two.css 1.01 KB 1.01 KB 0.52 KB 🔴 ⬆ 0.02 KB
themes/spectrum.css 1.04 KB 1.01 KB 0.52 KB -
* Size is the sum of all main files for packages in the library.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

Copy link
Contributor

🚀 Deployed on https://pr-3574--spectrum-css.netlify.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant