feat(storybook): live modifiers preview #4029
Draft
+45,407
−9,217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6aa7778 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
castastrophe
force-pushed
the
castastrophe/feat-storybook-modifiers-docs
branch
from
c7f092d to
5560468
Compare
File metricsSummaryTotal size: 1.44 MB*
File change detailsaccordion
actionbar
actionbutton
actiongroup
alertbanner
alertdialog
asset
assetcard
assetlist
avatar
badge
breadcrumb
button
buttongroup
calendar
card
checkbox
clearbutton
closebutton
coachindicator
coachmark
colorarea
colorhandle
colorloupe
colorslider
colorwheel
combobox
contextualhelp
datepicker
dial
dialog
divider
dropindicator
dropzone
fieldgroup
fieldlabel
floatingactionbutton
form
helptext
icon
illustratedmessage
infieldbutton
infieldprogresscircle
inlinealert
link
logicbutton
menu
meter
miller
modal
opacitycheckerboard
page
pagination
picker
pickerbutton
popover
progressbar
progresscircle
radio
rating
search
sidenav
slider
splitview
statuslight
steplist
stepper
swatch
swatchgroup
switch
table
tabs
tag
taggroup
textfield
thumbnail
toast
tooltip
tray
treeview
typography
underlay
well
* An ASCII character in UTF-8 is 8 bits or 1 byte. |
|
🚀 Deployed on https://pr-4029--spectrum-css.netlify.app |
castastrophe
force-pushed
the
castastrophe/feat-storybook-modifiers-docs
branch
16 times, most recently
from
6f72180 to
e804721
Compare
castastrophe
force-pushed
the
castastrophe/feat-storybook-modifiers-docs
branch
7 times, most recently
from
4f50fdd to
9cd6523
Compare
castastrophe
force-pushed
the
castastrophe/feat-storybook-modifiers-docs
branch
2 times, most recently
from
c8711e8 to
090e9bb
Compare
castastrophe
force-pushed
the
castastrophe/feat-storybook-modifiers-docs
branch
4 times, most recently
from
7898542 to
afbd50a
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
castastrophe
force-pushed
the
castastrophe/feat-storybook-modifiers-docs
branch
4 times, most recently
from
8927cef to
9be76b9
Compare
| --spectrum-thumbnail-border-color-selected: var(--highcontrast-thumbnail-border-color-selected, var(--mod-thumbnail-border-color-selected, var(--spectrum-accent-color-800))); | ||
| --spectrum-thumbnail-border-width: var(--mod-thumbnail-border-width, var(--spectrum-border-width-100)); | ||
| --spectrum-thumbnail-border-width-selected: var(--mod-thumbnail-border-width-selected, var(--spectrum-border-width-200)); | ||
| --spectrum-thumbnail-border-radius-default: var(--mod-thumbnail-border-radius, var(--spectrum-thumbnail-border-radius)); |
There was a problem hiding this comment.
Unused custom property --spectrum-thumbnail-border-radius-default defined
| @@ -86,6 +86,24 @@ | |||
| } | |||
|
|
|||
| .spectrum-Thumbnail { | |||
| --spectrum-thumbnail-size: var(--mod-thumbnail-size, var(--spectrum-thumbnail-sized-size)); | |||
There was a problem hiding this comment.
Custom property --spectrum-thumbnail-sized-size not defined
| }, | ||
| tags: ["migrated"], | ||
| decorators: [ | ||
| withUnderlayWrapper, | ||
| ], | ||
| tags: ["migrated"], |
There was a problem hiding this comment.
🚫 [eslint] <no-dupe-keys> reported by reviewdog 🐶
Duplicate key 'tags'.
castastrophe
force-pushed
the
castastrophe/feat-storybook-modifiers-docs
branch
2 times, most recently
from
f4f855a to
8e4bf00
Compare
castastrophe
force-pushed
the
castastrophe/feat-storybook-modifiers-docs
branch
from
8e4bf00 to
6aa7778
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
Regression testing
Validate:
Screenshots
To-do list