This repository has been archived by the owner on Feb 13, 2025. It is now read-only.
MWPW-141440 Improve Bulk Updating #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meganthecoder
approved these changes
Jan 22, 2024
test/bulk-update/bulk-update.test.js
Outdated
|
|
||
| describe('BulkUpdater', () => { | ||
| describe('loadFromUrl', () => { | ||
| it('should load data from a URL'); |
There was a problem hiding this comment.
Not testing anything here?
There was a problem hiding this comment.
I updated these tests with dependency injection for fetch
test/bulk-update/bulk-update.test.js
Outdated
Comment on lines
63
to
65
| it('should call migration.init'); | ||
|
|
||
| it('should call migration.migrate'); |
There was a problem hiding this comment.
I created a new test for this after some refactoring.
| @@ -71,7 +71,7 @@ describe('DocumentManager', () => { | |||
|
|
|||
| it('loads a mock file'); | |||
|
|
|||
| it('loads a draft file', async () => { | |||
| it.skip('loads a draft file', async () => { | |||
There was a problem hiding this comment.
Why the skip? If it needs more work, do we have a ticket for that?
There was a problem hiding this comment.
Occasionally this test would time out, but I updated these tests with dependency injection for fetch so no more skip needed.
JasonHowellSlavin
approved these changes
Jan 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: MWPW-141440