This repository has been archived by the owner on Feb 13, 2025. It is now read-only.
MWPW-141219 FaaS Report #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brandon32
force-pushed
the
bmarshal/faas-report
branch
from
ce36527 to
bc07021
Compare
Brandon32
force-pushed
the
bmarshal/faas-report
branch
from
bc07021 to
3f39207
Compare
meganthecoder
approved these changes
Feb 6, 2024
JasonHowellSlavin
approved these changes
Feb 6, 2024
test/bulk-update/bulk-update.test.js
Outdated
| @@ -65,6 +85,12 @@ describe('BulkUpdater', () => { | |||
| expect(data).to.deep.equal(expectedData); | |||
| }); | |||
|
|
|||
| it('should return an empty array if source is not provided', async () => { | |||
There was a problem hiding this comment.
nit: should return -> returns
| }); | ||
|
|
||
| describe('getVariantName', () => { | ||
| const tests = [[0, 'A'], [25, 'Z'], [26, 'AA'], [51, 'AZ'], [52, 'BA'], [77, 'BZ'], [78, 'CA'], [701, 'ZZ'], [702, 'AAA']]; |
There was a problem hiding this comment.
might be good to put something unexpected in here to test mixed inputs?
There was a problem hiding this comment.
Added a test for unexpected inputs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: MWPW-141219