Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mwpw-167662): add ability to have alt cta work with overlays #251

Merged
merged 3 commits into from
Feb 25, 2025

Conversation

sheridansunier
Copy link
Collaborator

@sheridansunier sheridansunier commented Feb 24, 2025

Resolves: MWPW-167662

We were observing that altCtas were not working with overlays - we observed this behavior during MAX and planned to fix it for Summit :)

URL: https://business.adobe.com/summit/adobe-summit.html?servertime=1742333400000
................................
Steps to Reproduce:

  1. Set up card collection based on the Strategy Keynotes section in https://business.adobe.com/summit/adobe-summit.html?servertime=1742333400000
  2. Enable Overlay Links
  3. Enable Live CTA change in the configuration

Expected Results: When cards are Live, the Overlay link also is updated with the altCTA HREF

Copy link

Core Web Vitals Metrics

Metric Value
LCP 12676.50 s
FID 0.80 ms
CLS N/A

Recorded at: 2025-02-24T20:37:18.699Z
PR: #251

Copy link

Core Web Vitals Metrics

Metric Value
LCP 10371.90 s
FID 0.60 ms
CLS N/A

Recorded at: 2025-02-24T20:40:19.039Z
PR: #251

Copy link

Core Web Vitals Metrics

Metric Value
LCP 13690.20 s
FID 0.70 ms
CLS N/A

Recorded at: 2025-02-25T19:45:37.188Z
PR: #251

@sheridansunier sheridansunier merged commit 22404e3 into main Feb 25, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants