Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release] Stage to Main 08/01 #380

Merged
merged 9 commits into from
Aug 8, 2024
Merged

[Release] Stage to Main 08/01 #380

merged 9 commits into from
Aug 8, 2024

Conversation

milo-pr-merge-cc[bot]
Copy link

@milo-pr-merge-cc milo-pr-merge-cc bot commented Aug 1, 2024 •
edited by salonijain3
Loading

@aishwaryamathuria
MWPW-154549 | Integrating unity Block in CC (#379)
f42e056 
Adding unity block in CC
Resolves: MWPW-154549
@milo-pr-merge-cc milo-pr-merge-cc bot requested a review from a team as a code owner August 1, 2024 16:18
@milo-pr-merge-cc
Copy link
Author

Testing can start @adobecom/creative-cloud-sot

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Aug 1, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Aug 1, 2024 •
edited
Loading

Page Scores Audits Google
/?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync aem-code-sync bot temporarily deployed to eagerloadHeroMarquee August 5, 2024 06:08 Inactive
@Ruchika4 @aishwaryamathuria @salonijain3
MWPW-155183 - Add new workflow to support premiere pro page (#377)
a9062bc 
* Update interactive-metadata.js

* Update interactive-metadata.js

* poc

* poc

* start over workflow

* optimize

* fix lint issues

* wip

* fix intermittent video loading issue

* fix mobile-heading-top for video

* optimize

* fix safari issue

* poster-image

* poster image

---------

Co-authored-by: Aishwarya Mathuria <[email protected]>
Co-authored-by: Saloni Jain <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 82.35294% with 6 lines in your changes missing coverage. Please review.

Project coverage is 88.36%. Comparing base (02e4e42) to head (6ad8963).
Report is 104 commits behind head on main.

Files Patch % Lines
...locks/interactive-metadata/interactive-metadata.js 78.57% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #380      +/-   ##
==========================================
+ Coverage   86.69%   88.36%   +1.66%     
==========================================
  Files           9       18       +9     
  Lines         947     2475    +1528     
==========================================
+ Hits          821     2187    +1366     
- Misses        126      288     +162

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aishwaryamathuria aishwaryamathuria self-requested a review August 7, 2024 18:00
aishwaryamathuria
aishwaryamathuria previously requested changes Aug 7, 2024
View reviewed changes
Copy link
Collaborator

@aishwaryamathuria aishwaryamathuria left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverting the Unity PR is required till guest access token is enabled on prod.

@aishwaryamathuria aishwaryamathuria self-requested a review August 8, 2024 07:57
@aishwaryamathuria
Copy link
Collaborator

Reverting the Unity PR till guest access token is enabled on prod.
@suhjainadobe @salonijain3 please merge the following revert before merging this sync PR #385

@spadmasa
Copy link
Collaborator

spadmasa commented Aug 8, 2024

Validation done on the below pr
#374
#377
#381
#382
and stage results are updated in https://jira.corp.adobe.com/browse/MWPW-153405
https://jira.corp.adobe.com/browse/MWPW-155571
https://jira.corp.adobe.com/browse/MWPW-155431
https://jira.corp.adobe.com/browse/MWPW-155931

@salonijain3
Merge pull request #385 from adobecom/revert-379-MWPW-154549
84dd522 
Revert "MWPW-154549 | Integrating unity Block in CC"
@spadmasa spadmasa added the ready for main PR is ready to be merged to main branch label Aug 8, 2024
@salonijain3 salonijain3 dismissed aishwaryamathuria’s stale review August 8, 2024 10:17

Unity PR is reverted.

@salonijain3 salonijain3 merged commit 6787405 into main Aug 8, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salonijain3 salonijain3 salonijain3 approved these changes

@suhjainadobe suhjainadobe suhjainadobe approved these changes

@aishwaryamathuria aishwaryamathuria Awaiting requested review from aishwaryamathuria

Assignees
No one assigned
Labels
ready for main PR is ready to be merged to main branch verified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@codecov-commenter @aishwaryamathuria @spadmasa @salonijain3 @suhjainadobe @3ch023 @Ruchika4