Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MWPW-157950 | Migrating CC to unity V2 for performance and flexibility #586

Merged
merged 5 commits into from
Feb 25, 2025
Merged

MWPW-157950 | Migrating CC to unity V2 for performance and flexibility #586

merged 5 commits into from
Feb 25, 2025

Conversation

aishwaryamathuria
Copy link
Collaborator

@aishwaryamathuria aishwaryamathuria commented Jan 28, 2025 •
edited
Loading

@aishwaryamathuria aishwaryamathuria requested a review from a team as a code owner January 28, 2025 06:06
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jan 28, 2025 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jan 28, 2025 •
edited
Loading

Page Scores Audits Google
📱 /products/photoshop/remove-background?unityversion=v2&unitylibs=psv2migration&ma
rtech=off&georouting=off		 PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /products/photoshop/remove-background?unityversion=v2&unitylibs=psv2migration&ma
rtech=off&georouting=off		 PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@milo-pr-merge-cc
Copy link

Skipped merging 586: MWPW-157950 | Migrating CC to unity V2 for performance and flexibility due to missing verified label. kindly make sure that the PR has been verified

1 similar comment
@milo-pr-merge-cc
Copy link

Skipped merging 586: MWPW-157950 | Migrating CC to unity V2 for performance and flexibility due to missing verified label. kindly make sure that the PR has been verified

@milo-pr-merge-cc
Copy link

Skipped merging 586: MWPW-157950 | Migrating CC to unity V2 for performance and flexibility due to missing verified label. kindly make sure that the PR has been verified

@milo-pr-merge-cc
Copy link

Skipped merging 586: MWPW-157950 | Migrating CC to unity V2 for performance and flexibility due to missing verified label. kindly make sure that the PR has been verified

@milo-pr-merge-cc
Copy link

Skipped merging 586: MWPW-157950 | Migrating CC to unity V2 for performance and flexibility due to missing verified label. kindly make sure that the PR has been verified

2 similar comments
@milo-pr-merge-cc
Copy link

Skipped merging 586: MWPW-157950 | Migrating CC to unity V2 for performance and flexibility due to missing verified label. kindly make sure that the PR has been verified

@milo-pr-merge-cc
Copy link

Skipped merging 586: MWPW-157950 | Migrating CC to unity V2 for performance and flexibility due to missing verified label. kindly make sure that the PR has been verified

@aem-code-sync aem-code-sync bot temporarily deployed to unityv2migration February 7, 2025 07:46 Inactive
@milo-pr-merge-cc
Copy link

Skipped merging 586: MWPW-157950 | Migrating CC to unity V2 for performance and flexibility due to missing verified label. kindly make sure that the PR has been verified

3 similar comments
@milo-pr-merge-cc
Copy link

Skipped merging 586: MWPW-157950 | Migrating CC to unity V2 for performance and flexibility due to missing verified label. kindly make sure that the PR has been verified

@milo-pr-merge-cc
Copy link

Skipped merging 586: MWPW-157950 | Migrating CC to unity V2 for performance and flexibility due to missing verified label. kindly make sure that the PR has been verified

@milo-pr-merge-cc
Copy link

Skipped merging 586: MWPW-157950 | Migrating CC to unity V2 for performance and flexibility due to missing verified label. kindly make sure that the PR has been verified

@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.64%. Comparing base (0e2e3d1) to head (0285de2).
Report is 27 commits behind head on stage.

Additional details and impacted files 
@@            Coverage Diff             @@
##            stage     #586      +/-   ##
==========================================
+ Coverage   88.73%   92.64%   +3.90%     
==========================================
  Files          33       34       +1     
  Lines        6713     7066     +353     
==========================================
+ Hits         5957     6546     +589     
+ Misses        756      520     -236

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@milo-pr-merge-cc
Copy link

Skipped merging 586: MWPW-157950 | Migrating CC to unity V2 for performance and flexibility due to failing checks

4 similar comments
@milo-pr-merge-cc
Copy link

Skipped merging 586: MWPW-157950 | Migrating CC to unity V2 for performance and flexibility due to failing checks

@milo-pr-merge-cc
Copy link

Skipped merging 586: MWPW-157950 | Migrating CC to unity V2 for performance and flexibility due to failing checks

@milo-pr-merge-cc
Copy link

Skipped merging 586: MWPW-157950 | Migrating CC to unity V2 for performance and flexibility due to failing checks

@milo-pr-merge-cc
Copy link

Skipped merging 586: MWPW-157950 | Migrating CC to unity V2 for performance and flexibility due to failing checks

@milo-pr-merge-cc
Copy link

Skipped merging 586: MWPW-157950 | Migrating CC to unity V2 for performance and flexibility due to missing verified label. kindly make sure that the PR has been verified

@sigadamvenkata
Copy link
Collaborator

since many unity features can not be validated in given branch (sample below), we do complete sanlty on STAGE.
{5CAC9EC2-C1BB-4C78-BB5C-B9DAAFD5672E}

@sigadamvenkata sigadamvenkata self-assigned this Feb 25, 2025
@aishwaryamathuria aishwaryamathuria merged commit 6b3c57c into stage Feb 25, 2025
9 checks passed
@aishwaryamathuria aishwaryamathuria mentioned this pull request Feb 25, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amitbikram amitbikram amitbikram approved these changes

@Ruchika4 Ruchika4 Ruchika4 approved these changes

@suhjainadobe suhjainadobe suhjainadobe approved these changes

@salonijain3 salonijain3 Awaiting requested review from salonijain3

@drashti1712 drashti1712 Awaiting requested review from drashti1712

@sanjayms01 sanjayms01 Awaiting requested review from sanjayms01

Assignees

@sigadamvenkata sigadamvenkata

Labels
ready for stage verified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aishwaryamathuria @codecov-commenter @sigadamvenkata @amitbikram @Ruchika4 @suhjainadobe