Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MWPW-167101 [Connect]Numbers are getting accepted in the name filed #618

Merged
merged 2 commits into from
Feb 13, 2025
Merged

MWPW-167101 [Connect]Numbers are getting accepted in the name filed #618

merged 2 commits into from
Feb 13, 2025

Conversation

suhjainadobe
Copy link
Contributor

@suhjainadobe suhjainadobe commented Feb 12, 2025 •
edited by aishwaryamathuria
Loading

[Connect]Numbers are getting accepted in the name filed

Resolves: MWPW-167101

Test URLs:

@suhjainadobe suhjainadobe requested a review from a team as a code owner February 12, 2025 12:13
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Feb 12, 2025 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Feb 12, 2025 •
edited
Loading

Page Scores Audits Google
📱 /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@milo-pr-merge-cc
Copy link

Skipped merging 618: MWPW-167101 [Connect]Numbers are getting accepted in the name filed due to missing verified label. kindly make sure that the PR has been verified

@spadmasa
Copy link
Collaborator

Validation can be done once pr is merged to stage

@milo-pr-merge-cc
Copy link

Skipped 618: MWPW-167101 [Connect]Numbers are getting accepted in the name filed due to file overlap. Merging will be attempted in the next batch

@aishwaryamathuria aishwaryamathuria merged commit 329c8a5 into stage Feb 13, 2025
10 checks passed
@aishwaryamathuria aishwaryamathuria mentioned this pull request Feb 18, 2025
Merged
@spadmasa spadmasa added the ready for main PR is ready to be merged to main branch label Feb 19, 2025
@aishwaryamathuria aishwaryamathuria mentioned this pull request Feb 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aishwaryamathuria aishwaryamathuria aishwaryamathuria approved these changes

@drashti1712 drashti1712 drashti1712 approved these changes

Assignees

@spadmasa spadmasa

@asonnalagi asonnalagi

Labels
ready for main PR is ready to be merged to main branch ready for stage verified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@suhjainadobe @spadmasa @aishwaryamathuria @drashti1712 @asonnalagi