-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support both .aem. and .hlx. - HLX5 Support #621
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a739738.
drashti1712
approved these changes
Feb 13, 2025
sharath-kannan
approved these changes
Feb 13, 2025
validation to be done once the pr is in stage |
aishwaryamathuria
pushed a commit
that referenced
this pull request
Feb 18, 2025
Reverts the config file changes of #621 Before: https://main--cc--adobecom.hlx.live/products/photoshop?martech=off After: https://hlx5-config-revert--cc--sharath-kannan.hlx.live/?martech=off After-2: https://hlx5-config-revert--cc--sharath-kannan.hlx.live/products/photoshop?martech=off
aishwaryamathuria
added a commit
that referenced
this pull request
Feb 19, 2025
This reverts commit 2bb5a54.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrading to aem.live from hlx.live as per the product requirements and docs.
This is not meant to be a complete PR but a spike to ensure you have everything you need and should be carefully QA'd
Todo's
aem.page
andaem.live
hlx.live
orhlx.page
Test URLs
All 4 variations should work:
hlx.page
aem.page
hlx.live
aem.live
Before: https://main--cc--adobecom.aem.live/products/photoshop?martech=off&georouting=off
After: https://revert-620-revert-484-hlx-5--cc--adobecom.hlx.live/products/photoshop?martech=off&georouting=off
After-2: https://revert-620-revert-484-hlx-5--cc--adobecom.aem.live/products/photoshop?martech=off&georouting=off
Known issues